From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id E199B7FEF for ; Thu, 7 Nov 2013 14:55:59 -0600 (CST) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay2.corp.sgi.com (Postfix) with ESMTP id C3490304062 for ; Thu, 7 Nov 2013 12:55:59 -0800 (PST) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) by cuda.sgi.com with ESMTP id EiVoGMaWclsKsoKT (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO) for ; Thu, 07 Nov 2013 12:55:58 -0800 (PST) Date: Thu, 7 Nov 2013 12:55:58 -0800 From: Christoph Hellwig Subject: Re: [PATCH 31/37] db: Unwind the IO stack on exit Message-ID: <20131107205558.GF23118@infradead.org> References: <1383700043-32305-1-git-send-email-david@fromorbit.com> <1383700043-32305-32-git-send-email-david@fromorbit.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1383700043-32305-32-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com On Wed, Nov 06, 2013 at 12:07:17PM +1100, Dave Chinner wrote: > From: Dave Chinner > > xfs_db can build up a large IO stack by the time it has run to > completion. If we don't unwind this IO stack before we shut down the > libxfs caches, metadump and other db programs will exit with > unreleased buffers and emit warnings like: > > cache_purge: shake on cache 0x69e4f0 left 7 nodes!? > > Hence we need to unwind the iostack as we shut down. Seems like this should be folded into patch 20, as that adds the first pop, but it seems to fail goind all the way. Otherwise looks good, Reviewed-by: Christoph Hellwig _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs