From: Dave Chinner <david@fromorbit.com>
To: Eryu Guan <eguan@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH v2 RESEND] xfstests generic/320: heavy rm workload test
Date: Tue, 12 Nov 2013 16:02:50 +1100 [thread overview]
Message-ID: <20131112050249.GZ6188@dastard> (raw)
In-Reply-To: <1384229890-30733-1-git-send-email-eguan@redhat.com>
On Tue, Nov 12, 2013 at 12:18:10PM +0800, Eryu Guan wrote:
> This test is based on generic/273, a regression test for commit
>
> 9a3a5da xfs: check for stale inode before acquiring iflock on push
>
> On unpatched kernel, rm processes would hang.
....
> +threads=50
> +count=2
> +fs_size=$((2 * 1024 * 1024 * 1024))
> +ORIGIN=$SCRATCH_MNT/origin
> +
> +threads_set()
> +{
> + cpu_num=`grep -c processor /proc/cpuinfo`
Please us src/feature for this. See commit:
2dcf4a5 xfstests: src/feature.c: print a number of online CPUs
> + threads=$(($cpu_num * 50))
> + if [ $threads -gt 200 ]
> + then
> + threads=200
> + fi
> +}
Didn't we go through this before? Or was that the review that lead
to the above commit? i.e. to use $LOAD_FACTOR to scale the workload,
not the number of CPUs....
> +
> +file_create()
> +{
> + i=0
> + mkdir $ORIGIN
> +
> + disksize=$(($fs_size / 3))
> + num=$(($disksize / $count / $threads / 4096))
> + while [ $i -lt $num ]; do
> + $XFS_IO_PROG -f -c "pwrite 0 $((4096*count))" $ORIGIN/file_$i >>$seqres.full 2>&1
Line too long.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-11-12 5:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-12 4:18 [PATCH v2 RESEND] xfstests generic/320: heavy rm workload test Eryu Guan
2013-11-12 5:02 ` Dave Chinner [this message]
2013-11-12 6:26 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131112050249.GZ6188@dastard \
--to=david@fromorbit.com \
--cc=eguan@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox