public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 RESEND] xfstests generic/320: heavy rm workload test
@ 2013-11-12  4:18 Eryu Guan
  2013-11-12  5:02 ` Dave Chinner
  0 siblings, 1 reply; 3+ messages in thread
From: Eryu Guan @ 2013-11-12  4:18 UTC (permalink / raw)
  To: xfs; +Cc: Eryu Guan

This test is based on generic/273, a regression test for commit

9a3a5da xfs: check for stale inode before acquiring iflock on push

On unpatched kernel, rm processes would hang.

Signed-off-by: Eryu Guan <eguan@redhat.com>
---
v2: Address Dave's comments
 - don't check return value of mkdir
 - don't cd to origin dir
 - don't calculate fs size, already have fs size
 - use $XFS_IO_PROG instead of dd
 - remove leading "_" from local vars
 - call _supported_fs etc. functions before any local functions
 - set status=0 before exit

 tests/generic/320     | 121 ++++++++++++++++++++++++++++++++++++++++++++++++++
 tests/generic/320.out |   2 +
 tests/generic/group   |   2 +-
 3 files changed, 124 insertions(+), 1 deletion(-)
 create mode 100755 tests/generic/320
 create mode 100644 tests/generic/320.out

diff --git a/tests/generic/320 b/tests/generic/320
new file mode 100755
index 0000000..09c533c
--- /dev/null
+++ b/tests/generic/320
@@ -0,0 +1,121 @@
+#! /bin/bash
+# FS QA Test No. generic/320
+#
+# heavy rm workload
+#
+# Regression test for commit:
+# 9a3a5da xfs: check for stale inode before acquiring iflock on push
+#
+# Based on generic/273
+#
+#-----------------------------------------------------------------------
+# Copyright (c) 2011-2012 Fujitsu, Inc.  All Rights Reserved.
+# Copyright (c) 2013 Red Hat, Inc.  All Rights Reserved.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it would be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write the Free Software Foundation,
+# Inc.,  51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+#
+#-----------------------------------------------------------------------
+#
+
+seq=`basename $0`
+seqres=$RESULT_DIR/$seq
+echo "QA output created by $seq"
+
+here=`pwd`
+tmp=/tmp/$$
+status=1	# failure is the default!
+trap "_cleanup; exit \$status" 0 1 2 3 15
+
+_cleanup()
+{
+	cd /
+	rm -rf $tmp.*
+}
+
+# get standard environment, filters and checks
+. ./common/rc
+. ./common/filter
+
+# real QA test starts here
+_supported_fs generic
+_supported_os IRIX Linux
+_require_scratch
+
+threads=50
+count=2
+fs_size=$((2 * 1024 * 1024 * 1024))
+ORIGIN=$SCRATCH_MNT/origin
+
+threads_set()
+{
+	cpu_num=`grep -c processor /proc/cpuinfo`
+	threads=$(($cpu_num * 50))
+	if [ $threads -gt 200 ]
+	then
+		threads=200
+	fi
+}
+
+file_create()
+{
+	i=0
+	mkdir $ORIGIN
+
+	disksize=$(($fs_size / 3))
+	num=$(($disksize / $count / $threads / 4096))
+	while [ $i -lt $num ]; do
+		$XFS_IO_PROG -f -c "pwrite 0 $((4096*count))" $ORIGIN/file_$i >>$seqres.full 2>&1
+		i=$(($i + 1))
+	done
+}
+
+worker()
+{
+	suffix=$1
+
+	mkdir $SCRATCH_MNT/sub_$suffix
+
+	cp -r $ORIGIN/* $SCRATCH_MNT/sub_$suffix >>$seqres.full 2>&1
+	rm -rf $SCRATCH_MNT/sub_$suffix
+}
+
+do_workload()
+{
+	pids=""
+	loop=1
+
+	threads_set
+	file_create
+
+	while [ $loop -lt $threads ]; do
+		worker $loop &
+		pids="$pids $!"
+		loop=$(($loop + 1))
+	done
+
+	wait $pids
+}
+
+echo "Silence is golden"
+
+rm -f $seqres.full
+
+_scratch_mkfs_sized $fs_size >>$seqres.full 2>&1
+_scratch_mount >>$seqres.full 2>&1
+
+do_workload
+
+_check_scratch_fs
+status=0
+exit
diff --git a/tests/generic/320.out b/tests/generic/320.out
new file mode 100644
index 0000000..1c4165d
--- /dev/null
+++ b/tests/generic/320.out
@@ -0,0 +1,2 @@
+QA output created by 320
+Silence is golden
diff --git a/tests/generic/group b/tests/generic/group
index 3488c42..40da6dc 100644
--- a/tests/generic/group
+++ b/tests/generic/group
@@ -122,4 +122,4 @@
 317 auto metadata quick
 318 acl attr auto quick
 319 acl auto quick
-
+320 auto rw
-- 
1.8.3.1

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2 RESEND] xfstests generic/320: heavy rm workload test
  2013-11-12  4:18 [PATCH v2 RESEND] xfstests generic/320: heavy rm workload test Eryu Guan
@ 2013-11-12  5:02 ` Dave Chinner
  2013-11-12  6:26   ` Eryu Guan
  0 siblings, 1 reply; 3+ messages in thread
From: Dave Chinner @ 2013-11-12  5:02 UTC (permalink / raw)
  To: Eryu Guan; +Cc: xfs

On Tue, Nov 12, 2013 at 12:18:10PM +0800, Eryu Guan wrote:
> This test is based on generic/273, a regression test for commit
> 
> 9a3a5da xfs: check for stale inode before acquiring iflock on push
> 
> On unpatched kernel, rm processes would hang.
....
> +threads=50
> +count=2
> +fs_size=$((2 * 1024 * 1024 * 1024))
> +ORIGIN=$SCRATCH_MNT/origin
> +
> +threads_set()
> +{
> +	cpu_num=`grep -c processor /proc/cpuinfo`

Please us src/feature for this. See commit:

2dcf4a5 xfstests: src/feature.c: print a number of online CPUs

> +	threads=$(($cpu_num * 50))
> +	if [ $threads -gt 200 ]
> +	then
> +		threads=200
> +	fi
> +}

Didn't we go through this before? Or was that the review that lead
to the above commit? i.e. to use $LOAD_FACTOR to scale the workload,
not the number of CPUs....

> +
> +file_create()
> +{
> +	i=0
> +	mkdir $ORIGIN
> +
> +	disksize=$(($fs_size / 3))
> +	num=$(($disksize / $count / $threads / 4096))
> +	while [ $i -lt $num ]; do
> +		$XFS_IO_PROG -f -c "pwrite 0 $((4096*count))" $ORIGIN/file_$i >>$seqres.full 2>&1

Line too long.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2 RESEND] xfstests generic/320: heavy rm workload test
  2013-11-12  5:02 ` Dave Chinner
@ 2013-11-12  6:26   ` Eryu Guan
  0 siblings, 0 replies; 3+ messages in thread
From: Eryu Guan @ 2013-11-12  6:26 UTC (permalink / raw)
  To: Dave Chinner; +Cc: xfs

On Tue, Nov 12, 2013 at 04:02:50PM +1100, Dave Chinner wrote:
> On Tue, Nov 12, 2013 at 12:18:10PM +0800, Eryu Guan wrote:
> > This test is based on generic/273, a regression test for commit
> > 
> > 9a3a5da xfs: check for stale inode before acquiring iflock on push
> > 
> > On unpatched kernel, rm processes would hang.
> ....
> > +threads=50
> > +count=2
> > +fs_size=$((2 * 1024 * 1024 * 1024))
> > +ORIGIN=$SCRATCH_MNT/origin
> > +
> > +threads_set()
> > +{
> > +	cpu_num=`grep -c processor /proc/cpuinfo`
> 
> Please us src/feature for this. See commit:
> 
> 2dcf4a5 xfstests: src/feature.c: print a number of online CPUs
> 
> > +	threads=$(($cpu_num * 50))
> > +	if [ $threads -gt 200 ]
> > +	then
> > +		threads=200
> > +	fi
> > +}
> 
> Didn't we go through this before? Or was that the review that lead
> to the above commit? i.e. to use $LOAD_FACTOR to scale the workload,
> not the number of CPUs....

Sorry, I may miss that part of review, will revise the patch.

> 
> > +
> > +file_create()
> > +{
> > +	i=0
> > +	mkdir $ORIGIN
> > +
> > +	disksize=$(($fs_size / 3))
> > +	num=$(($disksize / $count / $threads / 4096))
> > +	while [ $i -lt $num ]; do
> > +		$XFS_IO_PROG -f -c "pwrite 0 $((4096*count))" $ORIGIN/file_$i >>$seqres.full 2>&1
> 
> Line too long.

Ok, will update.

Thanks for the review!

Eryu
> 
> Cheers,
> 
> Dave.
> -- 
> Dave Chinner
> david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-11-12  6:26 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-12  4:18 [PATCH v2 RESEND] xfstests generic/320: heavy rm workload test Eryu Guan
2013-11-12  5:02 ` Dave Chinner
2013-11-12  6:26   ` Eryu Guan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox