From: Christoph Hellwig <hch@infradead.org>
To: Mark Tinguely <tinguely@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH v4] xfs: fix unlock in xfs_bmap_add_attrfork
Date: Tue, 12 Nov 2013 09:36:56 -0800 [thread overview]
Message-ID: <20131112173656.GE19554@infradead.org> (raw)
In-Reply-To: <20131107204358.901127238@.sgi.com>
On Thu, Nov 07, 2013 at 03:43:28PM -0600, Mark Tinguely wrote:
> xfs_trans_ijoin() activates the inode in a transaction and
> also can specify which lock to free when the transaction is
> committed or canceled.
>
> xfs_bmap_add_attrfork call locks and adds the lock to the
> transaction but also manually removes the lock. Change the
> routine to not add the lock to the transaction and manually
> remove lock on completion.
>
> While here, clean up the xfs_trans_cancel flags and goto names.
>
> Signed-off-by: Mark Tinguely <tinguely@sgi.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-11-12 17:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-07 21:43 [PATCH v4] xfs: fix unlock in xfs_bmap_add_attrfork Mark Tinguely
2013-11-12 17:36 ` Christoph Hellwig [this message]
2013-11-18 20:31 ` Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131112173656.GE19554@infradead.org \
--to=hch@infradead.org \
--cc=tinguely@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox