From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: stop special casing nfs and udf
Date: Tue, 12 Nov 2013 10:32:24 -0800 [thread overview]
Message-ID: <20131112183224.GA12213@infradead.org> (raw)
In-Reply-To: <52827113.3080609@sandeen.net>
On Tue, Nov 12, 2013 at 12:18:59PM -0600, Eric Sandeen wrote:
> On 11/7/13, 2:46 PM, Christoph Hellwig wrote:
> > For historical reasons beyond my knowledge xfstests tries to abuse the
> > scratch device as test device for nfs and udf. Because not all test
> > have inherited the right usage of the _setup_testdir and _cleanup_testdir
> > helpers this leads to lots of unessecary test failures.
> >
> > Remove the special casing, which gets nfs down to a minimal number of
> > failures.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
>
>
> Oof, that was a lot of cruft. Were you able to run UDF tests with
> these changes? I wonder if Jan is using this for UDF?
I didn't bother testing udf, but it's just another block based
filesystem, so unlike NFS I didn't expect breakage. Let me give it a
spin..
> (I don't have the UDF verifier that many(/all?) of the UDF tests
> require).
Last time I did run xfstests on UDF it wasn't required, just an
additional tool to verify the fs consistency.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-11-12 18:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-07 20:46 [PATCH] xfstests: stop special casing nfs and udf Christoph Hellwig
2013-11-12 17:35 ` Christoph Hellwig
2013-11-12 18:18 ` Eric Sandeen
2013-11-12 18:23 ` Eric Sandeen
2013-11-12 20:13 ` Jan Kara
2013-11-14 13:43 ` Christoph Hellwig
2013-11-12 18:32 ` Christoph Hellwig [this message]
2013-11-14 18:53 ` Eric Sandeen
2013-11-22 9:15 ` Christoph Hellwig
2013-12-02 17:40 ` Christoph Hellwig
2013-12-02 23:25 ` Dave Chinner
2013-12-02 23:36 ` Ben Myers
2013-12-03 4:29 ` Dave Chinner
2013-12-03 13:35 ` Rich Johnston
2013-12-03 23:30 ` Dave Chinner
2013-12-06 6:59 ` Stanislav Kholmanskikh
2013-12-06 16:06 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131112183224.GA12213@infradead.org \
--to=hch@infradead.org \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox