From: Jan Kara <jack@suse.cz>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Christoph Hellwig <hch@infradead.org>, Jan Kara <jack@suse.cz>,
xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: stop special casing nfs and udf
Date: Tue, 12 Nov 2013 21:13:43 +0100 [thread overview]
Message-ID: <20131112201343.GA31763@quack.suse.cz> (raw)
In-Reply-To: <52827239.9060307@sandeen.net>
On Tue 12-11-13 12:23:53, Eric Sandeen wrote:
> On 11/12/13, 12:18 PM, Eric Sandeen wrote:
> > On 11/7/13, 2:46 PM, Christoph Hellwig wrote:
> >> For historical reasons beyond my knowledge xfstests tries to abuse the
> >> scratch device as test device for nfs and udf. Because not all test
> >> have inherited the right usage of the _setup_testdir and _cleanup_testdir
> >> helpers this leads to lots of unessecary test failures.
> >>
> >> Remove the special casing, which gets nfs down to a minimal number of
> >> failures.
> >>
> >> Signed-off-by: Christoph Hellwig <hch@lst.de>
> >
> >
> > Oof, that was a lot of cruft. Were you able to run UDF tests with
> > these changes? I wonder if Jan is using this for UDF?
> >
> > (I don't have the UDF verifier that many(/all?) of the UDF tests
> > require).
No, I don't run xfstests for udf since there are only minimal changes
to udf these days and the problems tend to be more in compatibility with
various udf formats (since udf has about four ways how to do each thing and
you can decide which way your implementation does it which gets hairy when
you have to read all these combinations). But it's an interesting idea to
try running xfstests on UDF. I actually have the verifier so I should be
able to make it run...
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-11-12 20:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-07 20:46 [PATCH] xfstests: stop special casing nfs and udf Christoph Hellwig
2013-11-12 17:35 ` Christoph Hellwig
2013-11-12 18:18 ` Eric Sandeen
2013-11-12 18:23 ` Eric Sandeen
2013-11-12 20:13 ` Jan Kara [this message]
2013-11-14 13:43 ` Christoph Hellwig
2013-11-12 18:32 ` Christoph Hellwig
2013-11-14 18:53 ` Eric Sandeen
2013-11-22 9:15 ` Christoph Hellwig
2013-12-02 17:40 ` Christoph Hellwig
2013-12-02 23:25 ` Dave Chinner
2013-12-02 23:36 ` Ben Myers
2013-12-03 4:29 ` Dave Chinner
2013-12-03 13:35 ` Rich Johnston
2013-12-03 23:30 ` Dave Chinner
2013-12-06 6:59 ` Stanislav Kholmanskikh
2013-12-06 16:06 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131112201343.GA31763@quack.suse.cz \
--to=jack@suse.cz \
--cc=hch@infradead.org \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox