From: Dave Chinner <david@fromorbit.com>
To: Eryu Guan <eguan@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH v2] xfstests: _filter_mkfs should consume input from stdin for non-xfs fs
Date: Wed, 13 Nov 2013 09:08:16 +1100 [thread overview]
Message-ID: <20131112220816.GB6188@dastard> (raw)
In-Reply-To: <1384243158-19317-1-git-send-email-eguan@redhat.com>
On Tue, Nov 12, 2013 at 03:59:18PM +0800, Eryu Guan wrote:
> _filter_mkfs is a filter so that it should read from stdin first
> before printing anything out. Otherwise the command prior to the
> pipeline may get EPIPE.
>
> I saw this when testing extN with generic/204, _scratch_mkfs_sized was
> unable to create fs because of EPIPE, then _scratch_mount failed.
>
> generic/204 12s ... [failed, exit status 1] - output mismatch (see /root/xfstests/results//generic/204.out.bad)
> --- tests/generic/204.out 2013-11-01 16:47:56.728591856 +0800
> +++ /root/xfstests/results//generic/204.out.bad 2013-11-01 22:52:53.207828779 +0800
> @@ -1,2 +1,7 @@
> QA output created by 204
> -*** done
> +mount: wrong fs type, bad option, bad superblock on /dev/sda6,
> + missing codepage or helper program, or other error
> + In some cases useful info is found in syslog - try
> + dmesg | tail or so
> +
>
> Signed-off-by: Eryu Guan <eguan@redhat.com>
> ---
> v2: just pipe stdin to /dev/null for non-xfs fs as Dave suggested.
>
> common/filter | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/common/filter b/common/filter
> index e37ce69..c872a27 100644
> --- a/common/filter
> +++ b/common/filter
> @@ -138,6 +138,7 @@ _filter_mkfs()
> xfs)
> ;;
> *)
> + cat - >/dev/null
> perl -e 'print STDERR "dbsize=4096\nisize=256\n"'
> return ;;
> esac
Looks good.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-11-12 22:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-12 7:59 [PATCH v2] xfstests: _filter_mkfs should consume input from stdin for non-xfs fs Eryu Guan
2013-11-12 22:08 ` Dave Chinner [this message]
2013-11-13 3:34 ` Rich Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131112220816.GB6188@dastard \
--to=david@fromorbit.com \
--cc=eguan@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox