Re: [PATCH RFC] xfs: set block device logical sector size on xfs_buftarg

Ric Wheeler
2013-11-22T14:27:13Z

On 11/22/2013 09:20 AM, Christoph Hellwig wrote:
> On Fri, Nov 22, 2013 at 09:13:56AM -0500, Ric Wheeler wrote:
>> I think you do that by using SCSI debug to get a 4K sector drive -
>> that is how we tested for RHEL6 for example. Layering on
>> restrictions to hardware in the file system seems a bit harsh.
>>
>> The QEMU crowd will be working to get better support for 4K drives
>> in the future, but I think that we are effectively going to cause a
>> huge field issue here since these 512/4K drives are extremely
>> common..
>>
>> Given the SCSI debug method for this, does that mean you retract
>> your objections and will support Eric's patch :) ?
> We actually have a test for 4k drives using scsi_debug in xfstests: xfs/279.
>

Just to add on here. we are going to work more closely with the kvm/qemu people
to make sure that they properly take care of the hints about alignment and so on
(thanks to you for putting that in!).

Ric