From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfsprogs: Fix stray semicolon in libxfs/rdwr.c
Date: Fri, 15 Nov 2013 08:04:06 +1100 [thread overview]
Message-ID: <20131114210406.GQ6188@dastard> (raw)
In-Reply-To: <5285386A.8020800@redhat.com>
On Thu, Nov 14, 2013 at 02:54:02PM -0600, Eric Sandeen wrote:
> The commit:
>
> 800db1c1 libxfs: refactor libxfs_buf_read_map for xfs_db
>
> introduced a stray semicolon during the refactoring. Luckily it
> only breaks the error case.
>
> (Caught by Coverity, CID 1128894)
My fault, but really, this is something that gcc should warn about
because it's almost always a bug....
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> diff --git a/libxfs/rdwr.c b/libxfs/rdwr.c
> index 0aa2eba..0219a08 100644
> --- a/libxfs/rdwr.c
> +++ b/libxfs/rdwr.c
> @@ -754,7 +754,7 @@ libxfs_readbufr_map(struct xfs_buftarg *btp, struct xfs_buf *bp,
> offset += len;
> }
>
> - if (!error);
> + if (!error)
> bp->b_flags |= LIBXFS_B_UPTODATE;
> #ifdef IO_DEBUG
> printf("%lx: %s: read %u bytes, error %d, blkno=0x%llx(0x%llx), %p\n",
Looks good.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-11-14 21:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-14 20:54 [PATCH] xfsprogs: Fix stray semicolon in libxfs/rdwr.c Eric Sandeen
2013-11-14 21:04 ` Dave Chinner [this message]
2013-11-18 19:03 ` Rich Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131114210406.GQ6188@dastard \
--to=david@fromorbit.com \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox