[PATCH] xfsprogs: Fix stray semicolon in libxfs/rdwr.c

[PATCH] xfsprogs: Fix stray semicolon in libxfs/rdwr.c

[Eric Sandeen]

The commit:

800db1c1 libxfs: refactor libxfs_buf_read_map for xfs_db

introduced a stray semicolon during the refactoring.  Luckily it
only breaks the error case.

(Caught by Coverity, CID 1128894)

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

diff --git a/libxfs/rdwr.c b/libxfs/rdwr.c
index 0aa2eba..0219a08 100644
--- a/libxfs/rdwr.c
+++ b/libxfs/rdwr.c
@@ -754,7 +754,7 @@ libxfs_readbufr_map(struct xfs_buftarg *btp, struct xfs_buf *bp,
 		offset += len;
 	}
 
-	if (!error);
+	if (!error)
 		bp->b_flags |= LIBXFS_B_UPTODATE;
 #ifdef IO_DEBUG
 	printf("%lx: %s: read %u bytes, error %d, blkno=0x%llx(0x%llx), %p\n",

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfsprogs: Fix stray semicolon in libxfs/rdwr.c

[Dave Chinner]

On Thu, Nov 14, 2013 at 02:54:02PM -0600, Eric Sandeen wrote:
> The commit:
> 
> 800db1c1 libxfs: refactor libxfs_buf_read_map for xfs_db
> 
> introduced a stray semicolon during the refactoring.  Luckily it
> only breaks the error case.
> 
> (Caught by Coverity, CID 1128894)

My fault, but really, this is something that gcc should warn about
because it's almost always a bug....

> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
> 
> diff --git a/libxfs/rdwr.c b/libxfs/rdwr.c
> index 0aa2eba..0219a08 100644
> --- a/libxfs/rdwr.c
> +++ b/libxfs/rdwr.c
> @@ -754,7 +754,7 @@ libxfs_readbufr_map(struct xfs_buftarg *btp, struct xfs_buf *bp,
>  		offset += len;
>  	}
>  
> -	if (!error);
> +	if (!error)
>  		bp->b_flags |= LIBXFS_B_UPTODATE;
>  #ifdef IO_DEBUG
>  	printf("%lx: %s: read %u bytes, error %d, blkno=0x%llx(0x%llx), %p\n",

Looks good.

Reviewed-by: Dave Chinner <dchinner@redhat.com>

-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfsprogs: Fix stray semicolon in libxfs/rdwr.c

[Rich Johnston]

This has been committed.

Thanks
--Rich

Author: Eric Sandeen <sandeen@redhat.com>
Date:   Thu Nov 14 20:54:02 2013 +0000

     xfsprogs: Fix stray semicolon in libxfs/rdwr.c

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs