From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id C23F17F51 for ; Fri, 22 Nov 2013 09:17:36 -0600 (CST) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay3.corp.sgi.com (Postfix) with ESMTP id 4EA4BAC00A for ; Fri, 22 Nov 2013 07:17:36 -0800 (PST) Received: from bombadil.infradead.org ([198.137.202.9]) by cuda.sgi.com with ESMTP id QNC6kPw54RSgfpPI (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO) for ; Fri, 22 Nov 2013 07:17:35 -0800 (PST) Date: Fri, 22 Nov 2013 07:17:35 -0800 From: Christoph Hellwig Subject: Re: [PATCH] xfs: fix assertion failure at xfs_setattr_nonsize Message-ID: <20131122151735.GA2405@infradead.org> References: <528F743D.9010800@oracle.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <528F743D.9010800@oracle.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Jeff Liu Cc: "xfs@oss.sgi.com" On Fri, Nov 22, 2013 at 11:11:57PM +0800, Jeff Liu wrote: > To remain the current semantics under the debug mode, this fix add > an additional judgement to make this assertion only works for non-CRC > enabled version. > if (!gid_eq(igid, gid)) { > if (XFS_IS_QUOTA_RUNNING(mp) && XFS_IS_GQUOTA_ON(mp)) { > - ASSERT(!XFS_IS_PQUOTA_ON(mp)); > +#ifdef DEBUG > + if (!xfs_sb_version_has_pquotino(&mp->m_sb)) > + ASSERT(!XFS_IS_PQUOTA_ON(mp)); > +#endif > ASSERT(mask & ATTR_GID); > ASSERT(gdqp); I'd just kill this assert. And it would be good to get some coverage of running with all three quotas types into xfstests by default.. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs