* [PATCH] xfstests: generic/285: use the canonical device name
@ 2013-11-22 10:23 Stanislav Kholmanskikh
2013-11-22 15:35 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Stanislav Kholmanskikh @ 2013-11-22 10:23 UTC (permalink / raw)
To: xfs; +Cc: vasily.isaenko
In order to access something under /sys/fs/ext4 we
need to be sure that the device name is canonical
(It matters, for example, if we use LVM).
Signed-off-by: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
---
tests/generic/285 | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tests/generic/285 b/tests/generic/285
index 8078b1c..be31852 100755
--- a/tests/generic/285
+++ b/tests/generic/285
@@ -48,7 +48,7 @@ BASE_TEST_FILE=$TEST_DIR/seek_sanity_testfile
# Disable extent zeroing for ext4 as that change where holes are created
if [ "$FSTYP" = "ext4" ]; then
- DEV=`basename $TEST_DEV`
+ DEV=$(basename $(readlink -f $TEST_DEV))
echo 0 >/sys/fs/ext4/$DEV/extent_max_zeroout_kb
fi
--
1.7.1
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xfstests: generic/285: use the canonical device name
2013-11-22 10:23 [PATCH] xfstests: generic/285: use the canonical device name Stanislav Kholmanskikh
@ 2013-11-22 15:35 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2013-11-22 15:35 UTC (permalink / raw)
To: Stanislav Kholmanskikh; +Cc: vasily.isaenko, xfs
On Fri, Nov 22, 2013 at 02:23:03PM +0400, Stanislav Kholmanskikh wrote:
> In order to access something under /sys/fs/ext4 we
> need to be sure that the device name is canonical
> (It matters, for example, if we use LVM).
Did you try just using the canonical name all through xfstests, that
is canonicalise it after reading the config?
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-11-22 15:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-22 10:23 [PATCH] xfstests: generic/285: use the canonical device name Stanislav Kholmanskikh
2013-11-22 15:35 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox