From: Christoph Hellwig <hch@infradead.org>
To: Zhi Yong Wu <zwu.kernel@gmail.com>
Cc: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>, xfs@oss.sgi.com
Subject: Re: [RFC PATCH 4/4] xfs: allow linkat() on O_TMPFILE files
Date: Mon, 25 Nov 2013 05:51:49 -0800 [thread overview]
Message-ID: <20131125135149.GD30189@infradead.org> (raw)
In-Reply-To: <1385379154-3802-5-git-send-email-zwu.kernel@gmail.com>
> - ASSERT(ip->i_d.di_nlink > 0);
> + if ((VFS_I(ip)->i_nlink == 0) &&
> + !(VFS_I(ip)->i_state & I_LINKABLE))
> + ASSERT(ip->i_d.di_nlink > 0);
ASSERT(ip->i_d.di_nlink > 0 || (VFS_I(ip)->i_state & I_LINKABLE));
> @@ -1498,7 +1503,14 @@ xfs_link(
> tp = xfs_trans_alloc(mp, XFS_TRANS_LINK);
> cancel_flags = XFS_TRANS_RELEASE_LOG_RES;
> resblks = XFS_LINK_SPACE_RES(mp, target_name->len);
> - error = xfs_trans_reserve(tp, &M_RES(mp)->tr_link, resblks, 0);
> +
> + if ((VFS_I(sip)->i_nlink == 0) &&
> + (VFS_I(sip)->i_state & I_LINKABLE))
> + tres = &M_RES(mp)->tr_link_tmpfile;
> + else
> + tres = &M_RES(mp)->tr_link;
Just check i_nlink, and for consistency it might make sense to just use
the xfs_inode one. The VFS already made sure we don't inodes with
I_LINKABLE and a zero link count.
> + if ((VFS_I(sip)->i_nlink == 0) &&
> + (VFS_I(sip)->i_state & I_LINKABLE)) {
Same here.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-11-25 13:51 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-25 11:32 [RFC PATCH 0/4] xfs: add O_TMPFILE support Zhi Yong Wu
2013-11-25 11:32 ` [RFC PATCH 1/4] xfs: adjust the interface of xfs_qm_vop_dqalloc() Zhi Yong Wu
2013-11-25 13:43 ` Christoph Hellwig
2013-11-28 1:43 ` Zhi Yong Wu
2013-11-25 11:32 ` [RFC PATCH 2/4] xfs: add xfs_create_tmpfile() for O_TMPFILE support Zhi Yong Wu
2013-11-25 13:48 ` Christoph Hellwig
2013-11-28 1:48 ` Zhi Yong Wu
2013-11-25 21:36 ` Dave Chinner
2013-11-26 5:59 ` Christoph Hellwig
2013-11-28 2:41 ` Zhi Yong Wu
2013-11-25 11:32 ` [RFC PATCH 3/4] xfs: add a new method xfs_vn_tmpfile() Zhi Yong Wu
2013-11-25 13:48 ` Christoph Hellwig
2013-11-28 2:20 ` Zhi Yong Wu
2013-11-25 11:32 ` [RFC PATCH 4/4] xfs: allow linkat() on O_TMPFILE files Zhi Yong Wu
2013-11-25 13:51 ` Christoph Hellwig [this message]
2013-11-28 2:37 ` Zhi Yong Wu
2013-11-28 10:39 ` Christoph Hellwig
2013-11-28 10:47 ` Zhi Yong Wu
2013-11-25 21:46 ` Dave Chinner
2013-11-28 2:28 ` Zhi Yong Wu
2013-12-13 11:34 ` Zhi Yong Wu
2013-12-13 16:31 ` Christoph Hellwig
2013-11-28 10:35 ` [RFC PATCH 0/4] xfs: add O_TMPFILE support Christoph Hellwig
2013-11-28 10:50 ` Zhi Yong Wu
2013-11-28 14:39 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131125135149.GD30189@infradead.org \
--to=hch@infradead.org \
--cc=wuzhy@linux.vnet.ibm.com \
--cc=xfs@oss.sgi.com \
--cc=zwu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox