From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Zhi Yong Wu <zwu.kernel@gmail.com>,
Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>,
xfs@oss.sgi.com
Subject: Re: [RFC PATCH 2/4] xfs: add xfs_create_tmpfile() for O_TMPFILE support
Date: Mon, 25 Nov 2013 21:59:50 -0800 [thread overview]
Message-ID: <20131126055950.GA1376@infradead.org> (raw)
In-Reply-To: <20131125213601.GH8803@dastard>
On Tue, Nov 26, 2013 at 08:36:01AM +1100, Dave Chinner wrote:
>
> Is XFS_PROJID_DEFAULT correct here? If we are getting a parent inode
> from ->tmpfile, then this should be handled the same way as for
> xfs_create.
It should. And while we're at it that code from create and symlink
should be factored into:
static inline projid_t xfs_initial_projid(struct xfs_inode *dp)
{
if (dp->i_d.di_flags & XFS_DIFLAG_PROJINHERIT)
return xfs_get_projid(dp);
return XFS_PROJID_DEFAULT;
}
fist.
> I don't think this is necessary here. The ENOSPC flushing in
> xfs_create() is done to ensure we have space for directory block
> creation, not so much for inode allocation. Hence it doesn't make a
> lot of sense to have this here....
Point. I take back my earlier comment that it should be factored.
> I'm not sure that XFS_MOUNT_DIRSYNC shoul dbe checked here, as there
> is no directory operations to synchronise at all...
It probably shouldn't indeed. Reminds me of my old patch to make this
a flag to xfs_trans_commit instead of all that boilerplate code..
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-11-26 6:00 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-25 11:32 [RFC PATCH 0/4] xfs: add O_TMPFILE support Zhi Yong Wu
2013-11-25 11:32 ` [RFC PATCH 1/4] xfs: adjust the interface of xfs_qm_vop_dqalloc() Zhi Yong Wu
2013-11-25 13:43 ` Christoph Hellwig
2013-11-28 1:43 ` Zhi Yong Wu
2013-11-25 11:32 ` [RFC PATCH 2/4] xfs: add xfs_create_tmpfile() for O_TMPFILE support Zhi Yong Wu
2013-11-25 13:48 ` Christoph Hellwig
2013-11-28 1:48 ` Zhi Yong Wu
2013-11-25 21:36 ` Dave Chinner
2013-11-26 5:59 ` Christoph Hellwig [this message]
2013-11-28 2:41 ` Zhi Yong Wu
2013-11-25 11:32 ` [RFC PATCH 3/4] xfs: add a new method xfs_vn_tmpfile() Zhi Yong Wu
2013-11-25 13:48 ` Christoph Hellwig
2013-11-28 2:20 ` Zhi Yong Wu
2013-11-25 11:32 ` [RFC PATCH 4/4] xfs: allow linkat() on O_TMPFILE files Zhi Yong Wu
2013-11-25 13:51 ` Christoph Hellwig
2013-11-28 2:37 ` Zhi Yong Wu
2013-11-28 10:39 ` Christoph Hellwig
2013-11-28 10:47 ` Zhi Yong Wu
2013-11-25 21:46 ` Dave Chinner
2013-11-28 2:28 ` Zhi Yong Wu
2013-12-13 11:34 ` Zhi Yong Wu
2013-12-13 16:31 ` Christoph Hellwig
2013-11-28 10:35 ` [RFC PATCH 0/4] xfs: add O_TMPFILE support Christoph Hellwig
2013-11-28 10:50 ` Zhi Yong Wu
2013-11-28 14:39 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131126055950.GA1376@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=wuzhy@linux.vnet.ibm.com \
--cc=xfs@oss.sgi.com \
--cc=zwu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox