From: Christoph Hellwig <hch@infradead.org>
To: Jeff Liu <jeff.liu@oracle.com>
Cc: "xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [PATCH v2 2/3] xfs: fix infinite loop by detaching the group/project hints from user dquot
Date: Thu, 28 Nov 2013 02:43:36 -0800 [thread overview]
Message-ID: <20131128104336.GE26927@infradead.org> (raw)
In-Reply-To: <5294A469.1060000@oracle.com>
On Tue, Nov 26, 2013 at 09:38:49PM +0800, Jeff Liu wrote:
> + if (flags & XFS_QMOPT_UQUOTA)
> + return xfs_qm_dqpurge(dqp, NULL);
To me it doesn't make any sense to overload this function for the user
quotas that don't have hints.
I'd suggest dropping this hunk and keeping a separate walk for
releasing the uquots.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-11-28 10:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-26 13:38 [PATCH v2 2/3] xfs: fix infinite loop by detaching the group/project hints from user dquot Jeff Liu
2013-11-28 10:43 ` Christoph Hellwig [this message]
2013-11-29 9:36 ` Jeff Liu
2013-12-06 21:01 ` Ben Myers
2013-12-07 5:51 ` Jeff Liu
2013-12-09 1:26 ` Dave Chinner
2013-12-09 2:36 ` Dave Chinner
2013-12-09 3:26 ` Jeff Liu
2013-12-09 6:09 ` Dave Chinner
2013-12-09 6:36 ` Dave Chinner
2013-12-09 7:10 ` Christoph Hellwig
2013-12-09 23:07 ` Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131128104336.GE26927@infradead.org \
--to=hch@infradead.org \
--cc=jeff.liu@oracle.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox