Re: [PATCH] xfstests: stop special casing nfs and udf

Stanislav Kholmanskikh
2013-12-06T06:59:59Z

On 11/08/2013 12:46 AM, Christoph Hellwig wrote:
> For historical reasons beyond my knowledge xfstests tries to abuse the
> scratch device as test device for nfs and udf. Because not all test
> have inherited the right usage of the _setup_testdir and _cleanup_testdir
> helpers this leads to lots of unessecary test failures.
>
> Remove the special casing, which gets nfs down to a minimal number of
> failures.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> diff --git a/common/rc b/common/rc
> index ea3af12..c64933a 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -975,11 +975,7 @@ _require_scratch()
> {
> case "$FSTYP" in
> nfs*)
> - echo $SCRATCH_DEV | grep -q ":" > /dev/null 2>&1
> - if [ -z "$SCRATCH_DEV" -o "$?" != "0" ]
> - then
> - _notrun "this test requires a valid \$SCRATCH_DEV"
> - fi
> + _notrun "requires a scratch device"
> ;;
> *)
> if [ -z "$SCRATCH_DEV" -o "`_is_block_dev $SCRATCH_DEV`" = "" ]
> @@ -1773,100 +1769,6 @@ _full_platform_details()
> echo "$os/$platform $host $kernel"
> }
Hi!

Sorry for my post-commit "review".

But for what purposes did you delete this scratch device handling for nfs?
Now each test case that uses _require_scratch returns [not run].

It means most of the generic/ test cases.

I think we should revert this part of code. How do you think?

Thanks.