Re: [PATCH 05/18] fs: make posix_acl_chmod more useful

Andreas Gruenbacher
2013-12-12T19:07:26Z

Christoph,

> +int
> +posix_acl_chmod(struct inode *inode)
> +{
> + struct posix_acl *acl;
> + int ret = 0;
> +
> + if (S_ISLNK(inode->i_mode) || !inode->i_op->set_acl)
> + return -EOPNOTSUPP;

Symlinks never have get_acl callbacks, so I would remove the S_ISLNK() check here.

Andreas