From: Dave Chinner <david@fromorbit.com>
To: Jeff Liu <jeff.liu@oracle.com>
Cc: "xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [PATCH 2/3] xfstests: Introduce xfs/323 to verify turn group/project quotas off
Date: Tue, 3 Dec 2013 11:45:13 +1100 [thread overview]
Message-ID: <20131203004513.GJ10988@dastard> (raw)
In-Reply-To: <52983C48.50007@oracle.com>
On Fri, Nov 29, 2013 at 03:03:36PM +0800, Jeff Liu wrote:
> From: Jie Liu <jeff.liu@oracle.com>
>
> Introduce xfs/323 to verify that turn group/project quotas off
> while user quotas is on.
>
> Signed-off-by: Jie Liu <jeff.liu@oracle.com>
One minor thing:
> +# Modify as appropriate.
> +_supported_fs xfs
> +_supported_os Linux
> +
> +_require_scratch
> +_require_xfs_quota
> +_require_xfs_crc_sb
> +
> +_qmount_option "uquota,gquota,pquota"
> +_qmount
> +
> +TESTDIR=$SCRATCH_MNT/testdir
Too similar to TEST_DIR. "quota_dir", or something like it, so
people don't get confused by what device this test is running on at
a glance.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2013-12-03 0:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-29 7:03 [PATCH 2/3] xfstests: Introduce xfs/323 to verify turn group/project quotas off Jeff Liu
2013-12-03 0:45 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131203004513.GJ10988@dastard \
--to=david@fromorbit.com \
--cc=jeff.liu@oracle.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox