From: Dave Chinner <david@fromorbit.com>
To: Ben Myers <bpm@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [RFC PATCH] xfs: fix calculation of freed inode cluster blocks
Date: Wed, 4 Dec 2013 08:28:14 +1100 [thread overview]
Message-ID: <20131203212814.GW10988@dastard> (raw)
In-Reply-To: <20131203210054.GN1935@sgi.com>
On Tue, Dec 03, 2013 at 03:00:54PM -0600, Ben Myers wrote:
> rec.ir_startino is an agino rather than an ino. Use the correct macro
> when dealing with it in xfs_difree.
>
> ---
>
> This is very lightly tested so it's RFC. Looks like using "ino to
> agbno" is actually harmless when you pass in an agino, so there
> shouldn't have been any trouble caused by this one.
Right, the XFS_INO_TO_AGBNO() macro will behave correctly when
passed an agino - it's the same as an inode from AG 0. Changing the
macro to the correct one is effectively a no-op, so just send a
patch and get it reviewed and integrated...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2013-12-03 21:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 21:00 [RFC PATCH] xfs: fix calculation of freed inode cluster blocks Ben Myers
2013-12-03 21:28 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131203212814.GW10988@dastard \
--to=david@fromorbit.com \
--cc=bpm@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox