From: Ben Myers <bpm@sgi.com>
To: xfs@oss.sgi.com
Subject: [PATCH] xfs_repair: fix process_bmbt_reclist_int
Date: Tue, 3 Dec 2013 15:57:35 -0600 [thread overview]
Message-ID: <20131203215735.GQ1935@sgi.com> (raw)
There is a set checks for corruption in block map btrees in
process_bmbt_reclist_int that we identify but currently do not fix. It
appears that the author's intent in this function was to set error = 1,
and then only clear it when all of the checks were completed
successfully. Unfortunately error can be cleared when it is used for
the return value of blkmap_set_ext. Some kinds of corruption are not
being fixed, including duplicate extents, claiming free blocks, claiming
metadata blocks, and multiply used blocks.
Fix this by shadowing error for blkmap_set_ext.
Signed-off-by: Ben Myers <bpm@sgi.com>
---
repair/dinode.c | 1 +
1 file changed, 1 insertion(+)
Index: b/repair/dinode.c
===================================================================
--- a/repair/dinode.c 2013-12-03 15:43:59.895287548 -0600
+++ b/repair/dinode.c 2013-12-03 15:44:09.315225645 -0600
@@ -663,6 +663,7 @@ _("inode %" PRIu64 " - extent offset too
}
if (blkmapp && *blkmapp) {
+ int error;
error = blkmap_set_ext(blkmapp, irec.br_startoff,
irec.br_startblock, irec.br_blockcount);
if (error) {
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next reply other threads:[~2013-12-03 21:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 21:57 Ben Myers [this message]
2013-12-03 23:08 ` [PATCH] xfs_repair: fix process_bmbt_reclist_int Dave Chinner
2013-12-03 23:14 ` Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131203215735.GQ1935@sgi.com \
--to=bpm@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox