* [PATCH] xfs_repair: suggest reboot after dangerous repair
@ 2013-11-12 17:14 Eric Sandeen
2013-12-04 19:38 ` Ben Myers
2013-12-11 15:00 ` Rich Johnston
0 siblings, 2 replies; 4+ messages in thread
From: Eric Sandeen @ 2013-11-12 17:14 UTC (permalink / raw)
To: xfs-oss
If a "dangerous" repair (repair of a readonly mounted fs)
has been done, suggest an immediate reboot upon completion.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
TBH, I don't know how "dangerous" dangerous is. Is this
still required?
diff --git a/repair/xfs_repair.c b/repair/xfs_repair.c
index 820e7a2..9e1a774 100644
--- a/repair/xfs_repair.c
+++ b/repair/xfs_repair.c
@@ -884,6 +884,11 @@ _("Note - stripe unit (%d) and width (%d) fields have been reset.\n"
if (verbose)
summary_report();
do_log(_("done\n"));
+
+ if (dangerously && !no_modify)
+ do_warn(
+_("Repair of readonly mount complete. Immediate reboot encouraged.\n"));
+
pftrace_done();
return (0);
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] xfs_repair: suggest reboot after dangerous repair
2013-11-12 17:14 [PATCH] xfs_repair: suggest reboot after dangerous repair Eric Sandeen
@ 2013-12-04 19:38 ` Ben Myers
2013-12-04 19:42 ` Eric Sandeen
2013-12-11 15:00 ` Rich Johnston
1 sibling, 1 reply; 4+ messages in thread
From: Ben Myers @ 2013-12-04 19:38 UTC (permalink / raw)
To: Eric Sandeen; +Cc: xfs-oss
On Tue, Nov 12, 2013 at 11:14:46AM -0600, Eric Sandeen wrote:
> If a "dangerous" repair (repair of a readonly mounted fs)
> has been done, suggest an immediate reboot upon completion.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> TBH, I don't know how "dangerous" dangerous is. Is this
> still required?
Was there a crash or something after a repair that led to
this patch?
Reviewed-by: Ben Myers <bpm@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xfs_repair: suggest reboot after dangerous repair
2013-12-04 19:38 ` Ben Myers
@ 2013-12-04 19:42 ` Eric Sandeen
0 siblings, 0 replies; 4+ messages in thread
From: Eric Sandeen @ 2013-12-04 19:42 UTC (permalink / raw)
To: Ben Myers; +Cc: xfs-oss
On 12/4/13, 1:38 PM, Ben Myers wrote:
> On Tue, Nov 12, 2013 at 11:14:46AM -0600, Eric Sandeen wrote:
>> If a "dangerous" repair (repair of a readonly mounted fs)
>> has been done, suggest an immediate reboot upon completion.
>>
>> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
>> ---
>>
>> TBH, I don't know how "dangerous" dangerous is. Is this
>> still required?
>
> Was there a crash or something after a repair that led to
> this patch?
>
> Reviewed-by: Ben Myers <bpm@sgi.com>
>
No, it was generated by a "bug" saying that it was impossible
to run fsck.xfs on a root filesystem.
That was largely an RTFM kind of thing but since it's normal
for some systems to come up w/ RO-root in rescue mode, and people
are used to being able to run e2fsck in that mode, it might be worth
adding a little help to our tool to accomplish the same thing.
-Eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xfs_repair: suggest reboot after dangerous repair
2013-11-12 17:14 [PATCH] xfs_repair: suggest reboot after dangerous repair Eric Sandeen
2013-12-04 19:38 ` Ben Myers
@ 2013-12-11 15:00 ` Rich Johnston
1 sibling, 0 replies; 4+ messages in thread
From: Rich Johnston @ 2013-12-11 15:00 UTC (permalink / raw)
To: Eric Sandeen, xfs-oss
This has been committed.
Thanks
--Rich
commit 3ae81520e91945454f35fa75833a45b5b000fe33
Author: Eric Sandeen <sandeen@redhat.com>
Date: Tue Nov 12 17:14:46 2013 +0000
xfs_repair: suggest reboot after dangerous repair
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-12-11 15:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-12 17:14 [PATCH] xfs_repair: suggest reboot after dangerous repair Eric Sandeen
2013-12-04 19:38 ` Ben Myers
2013-12-04 19:42 ` Eric Sandeen
2013-12-11 15:00 ` Rich Johnston
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox