From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 4/5] xfs: use xfs_ilock_map_shared in xfs_attr_get
Date: Fri, 6 Dec 2013 08:05:57 +1100 [thread overview]
Message-ID: <20131205210557.GF29897@dastard> (raw)
In-Reply-To: <20131205210159.GA30318@infradead.org>
On Thu, Dec 05, 2013 at 01:01:59PM -0800, Christoph Hellwig wrote:
> On Fri, Dec 06, 2013 at 07:59:10AM +1100, Dave Chinner wrote:
> > I think the locking here should be moved inside xfs_attr_get_int()
>
> Or we could just kill xfs_attr_get_int..
>
> > so that it uses the same locking pattern as xfs_attr_set() and
> > xfs_attr_remove().
> >
> > Also, xfs_attr_list() needs this treatment (the attr version of
> > readdir) as well (and it has the locking inside xfs_attr_list_int(),
> > too ;).
> >
> > It looks like xfs_readlink needs fixing, too.
>
> Haven't really done an in-depth audit, mostly just looking at
> where the asserts kick in..
Right - I just did a scan with cscope on the users of
XFS_ILOCK_SHARED, and those two were the only ones that stuck out
that weren't handled correctly....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-12-05 21:06 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-05 15:58 [PATCH 0/5] extent list locking fixes Christoph Hellwig
2013-12-05 15:58 ` [PATCH 1/5] xfs: take the ilock around xfs_bmapi_read in xfs_zero_remaining_bytes Christoph Hellwig
2013-12-05 19:38 ` Ben Myers
2013-12-05 20:31 ` Dave Chinner
2013-12-05 20:37 ` Ben Myers
2013-12-05 20:40 ` Christoph Hellwig
2013-12-05 15:58 ` [PATCH 2/5] xfs: use xfs_ilock_map_shared in xfs_qm_dqtobp Christoph Hellwig
2013-12-05 19:46 ` Ben Myers
2013-12-05 20:41 ` Dave Chinner
2013-12-05 20:53 ` Christoph Hellwig
2013-12-05 21:03 ` Dave Chinner
2013-12-05 15:58 ` [PATCH 3/5] xfs: use xfs_ilock_map_shared in xfs_qm_dqiterate Christoph Hellwig
2013-12-05 19:48 ` Ben Myers
2013-12-05 20:45 ` Dave Chinner
2013-12-05 15:58 ` [PATCH 4/5] xfs: use xfs_ilock_map_shared in xfs_attr_get Christoph Hellwig
2013-12-05 19:57 ` Ben Myers
2013-12-05 20:59 ` Dave Chinner
2013-12-05 21:01 ` Christoph Hellwig
2013-12-05 21:05 ` Dave Chinner [this message]
2013-12-05 21:10 ` Christoph Hellwig
2013-12-05 21:17 ` Dave Chinner
2013-12-05 15:58 ` [PATCH 5/5] xfs: assert that we hold the ilock for extent map access Christoph Hellwig
2013-12-05 20:11 ` Ben Myers
2013-12-05 21:10 ` Dave Chinner
2013-12-05 21:22 ` Christoph Hellwig
2013-12-05 21:40 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131205210557.GF29897@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox