From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id C1E067F5F for ; Thu, 5 Dec 2013 15:06:07 -0600 (CST) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay2.corp.sgi.com (Postfix) with ESMTP id 9C649304051 for ; Thu, 5 Dec 2013 13:06:07 -0800 (PST) Received: from ipmail04.adl6.internode.on.net (ipmail04.adl6.internode.on.net [150.101.137.141]) by cuda.sgi.com with ESMTP id AtQHEzFr9iz8W4JA for ; Thu, 05 Dec 2013 13:06:05 -0800 (PST) Date: Fri, 6 Dec 2013 08:05:57 +1100 From: Dave Chinner Subject: Re: [PATCH 4/5] xfs: use xfs_ilock_map_shared in xfs_attr_get Message-ID: <20131205210557.GF29897@dastard> References: <20131205155830.620826868@bombadil.infradead.org> <20131205155951.679310054@bombadil.infradead.org> <20131205205910.GD29897@dastard> <20131205210159.GA30318@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20131205210159.GA30318@infradead.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Christoph Hellwig Cc: xfs@oss.sgi.com On Thu, Dec 05, 2013 at 01:01:59PM -0800, Christoph Hellwig wrote: > On Fri, Dec 06, 2013 at 07:59:10AM +1100, Dave Chinner wrote: > > I think the locking here should be moved inside xfs_attr_get_int() > > Or we could just kill xfs_attr_get_int.. > > > so that it uses the same locking pattern as xfs_attr_set() and > > xfs_attr_remove(). > > > > Also, xfs_attr_list() needs this treatment (the attr version of > > readdir) as well (and it has the locking inside xfs_attr_list_int(), > > too ;). > > > > It looks like xfs_readlink needs fixing, too. > > Haven't really done an in-depth audit, mostly just looking at > where the asserts kick in.. Right - I just did a scan with cscope on the users of XFS_ILOCK_SHARED, and those two were the only ones that stuck out that weren't handled correctly.... Cheers, Dave. -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs