Re: [PATCH] fs: fix iversion handling

J. Bruce Fields
2013-12-03T20:54:43Z

On Tue, Dec 03, 2013 at 12:40:54PM +0200, Boaz Harrosh wrote:
> On 12/03/2013 11:45 AM, Christoph Hellwig wrote:
> > On Tue, Dec 03, 2013 at 11:35:02AM +0200, Boaz Harrosh wrote:
> >> Hi Christoph
> >>
> >> What happens with all other filesystems exported under KNFSD?
> >>
> >> As I understand inode_inc_iversion() is used in NFSv4 and up,
> >> what will increment the inode-version on changed attributes
> >> for them?
> >
> > It's used by the filesystem for the change attribute that NFSDd
> > can optionally use. Most filesystsems don't support it and work
> > okay enough when NFS exported. No other filesystem will need
> > to adopt for this patch specificly, given that no other filesystem
> > uses this infrastructure.
> >
>
> OK Thanks, I did not know that. I assumed change-attribute is
> naturally supported.
>
> I will look at ext4 example and wire up exofs. Because it is very
> important for me to support the change-attribute properly.

Just please don't follow ext4's example of making support dependent on a
mount option.

--b.