Re: [PATCH] fs: fix iversion handling

Christoph Hellwig
2013-12-03T09:39:47Z

On Mon, Dec 02, 2013 at 03:05:07PM -0700, Andreas Dilger wrote:
> >> */
> >> - if (newsize != oldsize && (!(mask & (ATTR_CTIME | ATTR_MTIME))))
> >> - inode->i_ctime = inode->i_mtime = current_fs_time(inode->i_sb);
> >> + if (newsize != oldsize) {
> >> + inode_inc_iversion(inode);
>
> Should this be conditional on IS_I_VERSION(inode)?

btrfs sets MS_I_VERSION unconditionally.