Re: [PATCH 2/2] xfs free the list of recovery items on error.

Ben Myers
2013-12-04T20:51:09Z

On Wed, Oct 02, 2013 at 07:51:12AM -0500, Mark Tinguely wrote:
> Recovery builds a list of items on the transaction's
> r_itemq head. Normally these items are committed and freed.
> But in the event of a recovery error, these allocations
> are leaked.
>
> If the error occurs during item reordering, then reconstruct
> the r_itemq list before deleting the list to avoid leaking
> the entries that were on one of the temporary lists.
>
> Signed-off-by: Mark Tinguely <tinguely@sgi.com>

Looks good to me.
Reviewed-by: Ben Myers <bpm@sgi.com>