From: Christoph Hellwig <hch@infradead.org>
To: Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: stop special casing nfs and udf
Date: Fri, 6 Dec 2013 08:06:58 -0800 [thread overview]
Message-ID: <20131206160658.GA27329@infradead.org> (raw)
In-Reply-To: <52A175DD.5050908@oracle.com>
On Fri, Dec 06, 2013 at 10:59:41AM +0400, Stanislav Kholmanskikh wrote:
> Sorry for my post-commit "review".
>
> But for what purposes did you delete this scratch device handling for nfs?
> Now each test case that uses _require_scratch returns [not run].
>
> It means most of the generic/ test cases.
>
> I think we should revert this part of code. How do you think?
Tests really requiring a scratch device don't make sense for XFS,
as the scratch device is supposed to get recreated for every test.
However it seems like a lot of tests should simply run on the test
device. I'll take care of moving them over to use the test device.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2013-12-06 16:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-07 20:46 [PATCH] xfstests: stop special casing nfs and udf Christoph Hellwig
2013-11-12 17:35 ` Christoph Hellwig
2013-11-12 18:18 ` Eric Sandeen
2013-11-12 18:23 ` Eric Sandeen
2013-11-12 20:13 ` Jan Kara
2013-11-14 13:43 ` Christoph Hellwig
2013-11-12 18:32 ` Christoph Hellwig
2013-11-14 18:53 ` Eric Sandeen
2013-11-22 9:15 ` Christoph Hellwig
2013-12-02 17:40 ` Christoph Hellwig
2013-12-02 23:25 ` Dave Chinner
2013-12-02 23:36 ` Ben Myers
2013-12-03 4:29 ` Dave Chinner
2013-12-03 13:35 ` Rich Johnston
2013-12-03 23:30 ` Dave Chinner
2013-12-06 6:59 ` Stanislav Kholmanskikh
2013-12-06 16:06 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131206160658.GA27329@infradead.org \
--to=hch@infradead.org \
--cc=stanislav.kholmanskikh@oracle.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox