Re: [PATCH 10/18] hfsplus: use generic posix ACL infrastructure

Vyacheslav Dubeyko
2013-12-01T13:35:14Z

On Dec 1, 2013, at 2:59 PM, Christoph Hellwig wrote:

> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> fs/hfsplus/acl.h | 9 +--
> fs/hfsplus/dir.c | 1 +
> fs/hfsplus/inode.c | 3 +-
> fs/hfsplus/posix_acl.c | 161 +++++-------------------------------------------
> fs/hfsplus/xattr.c | 5 +-
> fs/hfsplus/xattr.h | 2 -
> 6 files changed, 24 insertions(+), 157 deletions(-)
>

Reviewed-by: Vyacheslav Dubeyko <slava@dubeyko.com>

The patch looks correct. I think only that it makes sense to add debug messages
in hfsplus_get_posix_acl() and hfsplus_set_posix_acl(). Previously, debug
messages were in hfsplus_xattr_get_posix_acl() and hfsplus_xattr_set_posix_acl()
but the patch removes these methods.

Thanks,
Vyacheslav Dubeyko.