From: Mark Tinguely <tinguely@sgi.com>
To: xfs@oss.sgi.com
Subject: [PATCH 0/2] misc log recovery patches
Date: Fri, 06 Dec 2013 15:20:27 -0600 [thread overview]
Message-ID: <20131206212027.846346746@sgi.com> (raw)
A couple log recovery patches.
patch 1 is a correction to commit:
commit 2a84108fe275f95fbe838b1c92b7c45258dcae5c
Author: Mark Tinguely <tinguely@sgi.com>
Date: Wed Oct 2 07:51:12 2013 -0500
xfs: free the list of recovery items on error
Errors in phase 1/2 of xlog_recover_commit_trans will free the
transaction pointer and the new call to xlog_recover_process_data
will reuse and refree the pointer. I missed it in testing of the
2a84108 patch. Found by Dan Carpenter and verified by forcing an
error in xlog_recover_process_data.
---
patch 2 is the second version of the patch to remove the EFI from
the AIL when log recovery of the EFI item fails. If the EFI entry is
not removed from the AIL, then xfs_ail_push_all_sync will hang while
doing the forced shutdown. I moved the removal of all EFIs from the
AIL to the caller, xlog_recover_process_efis to catch all the errors
coming from xlog_recover_process_efi. This bug was found and verified
using a metadata dump of a filesystem that has an error freeing an
extent.
Mark.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next reply other threads:[~2013-12-06 21:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-06 21:20 Mark Tinguely [this message]
2013-12-06 21:20 ` [PATCH 1/2] xfs: fix double free on error when cleaning log items Mark Tinguely
2013-12-09 0:29 ` Dave Chinner
2013-12-06 21:20 ` [PATCH 2/2] xfs: free the efi AIL entry on log recovery failure Mark Tinguely
2013-12-08 0:52 ` [PATCH v3] " Mark Tinguely
2013-12-09 1:00 ` Dave Chinner
2013-12-11 11:31 ` Christoph Hellwig
2013-12-11 17:25 ` Mark Tinguely
2013-12-23 16:42 ` Mark Tinguely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131206212027.846346746@sgi.com \
--to=tinguely@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox