From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id F180F7F8B for ; Sun, 8 Dec 2013 16:39:04 -0600 (CST) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay1.corp.sgi.com (Postfix) with ESMTP id DC2F68F8033 for ; Sun, 8 Dec 2013 14:39:04 -0800 (PST) Received: from ipmail06.adl2.internode.on.net (ipmail06.adl2.internode.on.net [150.101.137.129]) by cuda.sgi.com with ESMTP id miu2nyiQ5bhN23Xa for ; Sun, 08 Dec 2013 14:38:57 -0800 (PST) Date: Mon, 9 Dec 2013 09:38:26 +1100 From: Dave Chinner Subject: Re: [PATCH 08/11] xfs: use xfs_ilock_data_map_shared in xfs_qm_dqiterate Message-ID: <20131208223826.GI31386@dastard> References: <20131206203006.914776999@bombadil.infradead.org> <20131206203129.185131308@bombadil.infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20131206203129.185131308@bombadil.infradead.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Christoph Hellwig Cc: xfs@oss.sgi.com On Fri, Dec 06, 2013 at 12:30:14PM -0800, Christoph Hellwig wrote: > We might not have read in the extent list at this point, so make sure we > take the ilock exclusively if we have to do so. > > Signed-off-by: Christoph Hellwig > > Index: xfs/fs/xfs/xfs_qm.c > =================================================================== > --- xfs.orig/fs/xfs/xfs_qm.c 2013-12-06 17:20:27.491331600 +0100 > +++ xfs/fs/xfs/xfs_qm.c 2013-12-06 19:39:27.251160455 +0100 > @@ -1193,16 +1193,18 @@ xfs_qm_dqiterate( > lblkno = 0; > maxlblkcnt = XFS_B_TO_FSB(mp, mp->m_super->s_maxbytes); > do { > + uint lock_mode; > + > nmaps = XFS_DQITER_MAP_SIZE; > /* > * We aren't changing the inode itself. Just changing > * some of its data. No new blocks are added here, and > * the inode is never added to the transaction. > */ > - xfs_ilock(qip, XFS_ILOCK_SHARED); > + lock_mode = xfs_ilock_data_map_shared(qip); > error = xfs_bmapi_read(qip, lblkno, maxlblkcnt - lblkno, > map, &nmaps, 0); > - xfs_iunlock(qip, XFS_ILOCK_SHARED); > + xfs_iunlock(qip, lock_mode); > if (error) > break; looks good. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs