Re: [PATCH 01/10] xfs: remove duplicate code in xlog_cil_insert_format_items

Christoph Hellwig
2013-12-10T16:18:29Z

On Mon, Dec 09, 2013 at 01:45:48PM -0600, Ben Myers wrote:
> > + if (ordered) {
> > + /* track as an ordered logvec */
> > + ASSERT(lip->li_lv == NULL);
> > + lv->lv_buf_len = XFS_LOG_VEC_ORDERED;
> > + goto insert;
>
> It looks like lv->lv_niovecs is no longer being set in this case. Was that intentional?

Yes, ordered log vecs don't have iovecs attached, so the implicit zero
from the kmem_zalloc is the right value.