Re: [PATCH 06/10] xfs: format log items write directly into the linear CIL buffer

Christoph Hellwig
2013-12-10T16:12:30Z

On Mon, Dec 09, 2013 at 01:00:28PM -0600, Ben Myers wrote:
> > And if we need to guarantee alignment, then maybe roundup here to
> > ensure we don't end up with bad offsets? That would require padding
> > the allocation of the buffer to take it into account, too....
> >
> > Other than this concern, the code looks fine.
>
> Christoph, what about this alignment issue?

I think Dave is right, but I haven't had time to look at the issue in
detail and respin the patchset yet.