Re: [PATCH 05/10] xfs: introduce xlog_copy_iovec

Dave Chinner
2013-12-03T01:21:27Z

On Fri, Nov 29, 2013 at 12:39:24AM -0800, Christoph Hellwig wrote:
> Add a helper to abstract out filling the log iovecs in the log item format
> handlers. This will allow us to change the way we do the log item
> formatting more easily.
>
> The copy in the name is a bit confusing for now as it just assigns a
> pointer and lets the CIL code perform the copy, but that will change
> soon.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Looks good - I think the helper was worth the effort. ;)

Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com