From: Christoph Hellwig <hch@infradead.org>
To: Ben Myers <bpm@sgi.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH 06/10] xfs: format log items write directly into the linear CIL buffer
Date: Tue, 10 Dec 2013 08:12:23 -0800 [thread overview]
Message-ID: <20131210161223.GC19510@infradead.org> (raw)
In-Reply-To: <20131209190028.GW1935@sgi.com>
On Mon, Dec 09, 2013 at 01:00:28PM -0600, Ben Myers wrote:
> > And if we need to guarantee alignment, then maybe roundup here to
> > ensure we don't end up with bad offsets? That would require padding
> > the allocation of the buffer to take it into account, too....
> >
> > Other than this concern, the code looks fine.
>
> Christoph, what about this alignment issue?
I think Dave is right, but I haven't had time to look at the issue in
detail and respin the patchset yet.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-12-10 16:12 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-29 8:39 [PATCH 00/10] decouple the in-memory from the on-disk log format V2 Christoph Hellwig
2013-11-29 8:39 ` [PATCH 01/10] xfs: remove duplicate code in xlog_cil_insert_format_items Christoph Hellwig
2013-12-03 0:58 ` Dave Chinner
2013-12-09 19:45 ` Ben Myers
2013-12-10 16:18 ` Christoph Hellwig
2013-11-29 8:39 ` [PATCH 02/10] xfs: refactor xfs_buf_item_format_segment Christoph Hellwig
2013-12-03 1:03 ` Dave Chinner
2013-11-29 8:39 ` [PATCH 03/10] xfs: refactor xfs_inode_item_size Christoph Hellwig
2013-12-03 1:06 ` Dave Chinner
2013-11-29 8:39 ` [PATCH 04/10] xfs: refactor xfs_inode_item_format Christoph Hellwig
2013-12-03 1:10 ` Dave Chinner
2013-11-29 8:39 ` [PATCH 05/10] xfs: introduce xlog_copy_iovec Christoph Hellwig
2013-12-03 1:21 ` Dave Chinner
2013-12-03 9:43 ` Christoph Hellwig
2013-11-29 8:39 ` [PATCH 06/10] xfs: format log items write directly into the linear CIL buffer Christoph Hellwig
2013-12-04 0:37 ` Dave Chinner
2013-12-09 19:00 ` Ben Myers
2013-12-10 16:12 ` Christoph Hellwig [this message]
2013-12-11 12:03 ` [PATCH 06/10 v2] " Christoph Hellwig
2013-12-12 0:05 ` Dave Chinner
2013-12-12 16:25 ` [PATCH 06/10 v3] " Christoph Hellwig
2013-11-29 8:39 ` [PATCH 07/10] xfs: format logged extents directly into the CIL Christoph Hellwig
2013-12-04 0:40 ` Dave Chinner
2013-11-29 8:39 ` [PATCH 08/10] xfs: remove the inode log format from the inode log item Christoph Hellwig
2013-12-04 0:44 ` Dave Chinner
2013-11-29 8:39 ` [PATCH 09/10] xfs: remove the dquot log format from the dquot " Christoph Hellwig
2013-12-04 0:47 ` Dave Chinner
2013-11-29 8:39 ` [PATCH 10/10] xfs: remove the quotaoff log format from the quotaoff " Christoph Hellwig
2013-12-04 0:49 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131210161223.GC19510@infradead.org \
--to=hch@infradead.org \
--cc=bpm@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox