Re: [PATCH 06/10] xfstests: fix generic/225 to check fiemap support

Dave Chinner
2013-12-12T23:00:40Z

On Thu, Dec 12, 2013 at 02:44:47PM -0800, Junho Ryu wrote:
> >> I'd just rename if _require_fiemap, because we need both xfs_io and
> >> kernel support for it, and we need xfs_io support to check for
> >> kernel support....
> >
> > Fine with me.
>
> There are 3 more _require_xfs_io_.* functions. I can create another
> patch if you want these names to be consistent.
>
> _require_xfs_io_falloc()
> _require_xfs_io_falloc_punch()

yes, those 2 can be changed similar to _requires_fiemap

> _require_xfs_io_zero()

That one is only testing for xfs_io command support, so it should
remain the way it is...

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com