public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Ben Myers <bpm@sgi.com>
To: Jeff Liu <jeff.liu@oracle.com>
Cc: Eric Sandeen <sandeen@sandeen.net>, "xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs: return ENOSPC when trying to set more ACLs than XFS_ACL_MAX_ENTRIES
Date: Wed, 11 Dec 2013 13:36:22 -0600	[thread overview]
Message-ID: <20131211193622.GG1935@sgi.com> (raw)
In-Reply-To: <5292D8AB.5080003@oracle.com>

Hey Jeff,

On Mon, Nov 25, 2013 at 12:57:15PM +0800, Jeff Liu wrote:
> 
> On 11/25 2013 11:34 AM, Eric Sandeen wrote:
> > On 11/24/13, 9:36 AM, Jeff Liu wrote:
> >> From: Jie Liu <jeff.liu@oracle.com>
> >>
> >> We currently return EINVAL when trying to set more ACL entries than
> >> XFS_ACL_MAX_ENTRIES(), but it would be a bit more meaningful to return
> >> ENOSPC in this situation, because the later is used to indicate there
> >> is no more space to store new ACLs IMHO.
> > 
> > I'm not quite convinced that it's better; the user will get an
> > error string of "no space left on device" which is misleading too,
> I admit that both looks misleading...
> > and I'd argue that it's no better than "invalid argument."
> > 
> > To me, I think it's not worth changing, but others may disagree.
> > 
> > (I guess looking at ext4, it uses ENOSPC for some similar constraints,
> > so maybe three is precedent for this)
> Btrfs also uses ENOSPC, but JFS would return something like "Argument list too long"
> in this case.

I tend to agree with Eric on this one, but if Dave or Christoph want to weigh
in that's cool.

Thanks,
	Ben

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2013-12-11 19:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-24 15:36 [PATCH] xfs: return ENOSPC when trying to set more ACLs than XFS_ACL_MAX_ENTRIES Jeff Liu
2013-11-25  3:34 ` Eric Sandeen
2013-11-25  4:57   ` Jeff Liu
2013-12-11 19:36     ` Ben Myers [this message]
2013-12-12  3:26       ` Jeff Liu
2013-12-13 13:04       ` Christoph Hellwig
2013-12-13 13:32         ` Jeff Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131211193622.GG1935@sgi.com \
    --to=bpm@sgi.com \
    --cc=jeff.liu@oracle.com \
    --cc=sandeen@sandeen.net \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox