From: Dave Chinner <david@fromorbit.com>
To: Jeff Liu <jeff.liu@oracle.com>
Cc: "xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [PATCH 5/5] xfs: use xfs_ialloc_blks_per_cluster in xfs_imap
Date: Thu, 12 Dec 2013 10:39:38 +1100 [thread overview]
Message-ID: <20131211233938.GR10988@dastard> (raw)
In-Reply-To: <52A86D33.2020102@oracle.com>
On Wed, Dec 11, 2013 at 09:48:35PM +0800, Jeff Liu wrote:
> From: Jie Liu <jeff.liu@oracle.com>
>
> Use xfs_ialloc_blks_per_cluster() in xfs_imap(). Please note that we
> previously calculate the number of blocks per cluster without taking
> the situation of that the inode cluster size might be equal to or less
> than the SB blocksize into account. Maybe there is a chance to cause
> potential issues after handling an untrusted inode number lookup and
> proceed to check if the inode number maps to a block is outsides the
> file system bounds or not.
I don't think there's any issues here - after all the inode lookups
and mapping is done, the code in xfs_imap checks that the cluster
that the inode is mapped to lies wholly within the filesystem
boundaries. Hence I think you can remove that from the patch
descritpion.
Otherwise, looks good.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-12-11 23:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-11 13:48 [PATCH 5/5] xfs: use xfs_ialloc_blks_per_cluster in xfs_imap Jeff Liu
2013-12-11 23:39 ` Dave Chinner [this message]
2013-12-12 3:16 ` Jeff Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131211233938.GR10988@dastard \
--to=david@fromorbit.com \
--cc=jeff.liu@oracle.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox