public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	Junho Ryu <jayr@google.com>,
	hughd@google.com, branto@redhat.com, xfs@oss.sgi.com
Subject: Re: [PATCH 05/10] xfstests: do not unmount tmpfs during remount.
Date: Wed, 11 Dec 2013 19:16:55 -0500	[thread overview]
Message-ID: <20131212001655.GA31768@thunk.org> (raw)
In-Reply-To: <20131211224012.GJ10988@dastard>

On Thu, Dec 12, 2013 at 09:40:12AM +1100, Dave Chinner wrote:
> > 
> > All these tests don't make sense if you never unmount the filesystem.
> > Istead they should exit with _notrun for tmpfs.
> 
> IOWs, adding tmpfs changes the definition of a "generic" test.
> 
> i.e. instead of:
> 
> _supported_fs generic
> 
> these tests are now:
> 
> _supported_fs xfs ext2 ext3 ext4 ext4dev btrfs gfs2 nfs udf reiserfs
> 
> and by that definition should be in the tests/shared directory....

At a higher level, I wonder how useful having the distinction between
"generic" and "shared" really is.  Suppose in the future we add some
tests for networked file systems or cluster file systems --- do we end
up migrating even more tests from "generic" to "shared" when we find
tests that don't work for some new file system?

And to the extent that we have things like 

_require_<feature>

which skips certain tests, it's not even true that all generic tests
are run for all file systems.  So what should be the proper
distinction between generic and shared tests?  Whether we use
"_require_*" vs "_supported_fs"?  And if so, it seems rather arbitrary
that we decide whether not running a test based on the file system
type being <foo> is fundamentally different from deciding not to run a
test becuase we are missing the feature <bar>.

Perhaps it would make more sense to move all of the generic test to
shared, and eliminating the distinction?  That way it also becomes
easier becase we don't need to remember whether a test is generic/NNN
vs shared/NNN.  :-)

Just a thought,

					- Ted

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2013-12-12  0:17 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-10 20:11 [PATCH 00/10] Add tmpfs filesystem support Junho Ryu
2013-12-10 20:11 ` [PATCH 01/10] xfstests: Add tmpfs support Junho Ryu
2013-12-11  7:40   ` Christoph Hellwig
2013-12-17 16:40   ` Rich Johnston
2013-12-10 20:11 ` [PATCH 02/10] xfstests: use mount point instead of device name Junho Ryu
2013-12-11  7:42   ` Christoph Hellwig
2013-12-10 20:11 ` [PATCH 03/10] xfstests: _scratch_mkfs_sized() for tmpfs Junho Ryu
2013-12-11  7:44   ` Christoph Hellwig
2013-12-10 20:11 ` [PATCH 04/10] xfstests: increase tmpfs memory size Junho Ryu
2013-12-11  7:44   ` Christoph Hellwig
2013-12-10 20:11 ` [PATCH 05/10] xfstests: do not unmount tmpfs during remount Junho Ryu
2013-12-11  7:46   ` Christoph Hellwig
2013-12-11 22:40     ` Dave Chinner
2013-12-12  0:16       ` Theodore Ts'o [this message]
2013-12-12  0:53         ` Dave Chinner
2013-12-12 18:01       ` Christoph Hellwig
2013-12-12 22:56         ` Dave Chinner
2013-12-13  0:00           ` Junho Ryu
2013-12-13  1:41             ` Dave Chinner
2013-12-13 11:12               ` Christoph Hellwig
2013-12-13  4:56           ` Theodore Ts'o
2013-12-13 11:04           ` Christoph Hellwig
2013-12-10 20:11 ` [PATCH 06/10] xfstests: fix generic/225 to check fiemap support Junho Ryu
2013-12-11  7:46   ` Christoph Hellwig
2013-12-11 22:42     ` Dave Chinner
2013-12-12 18:01       ` Christoph Hellwig
2013-12-12 22:44         ` Junho Ryu
2013-12-12 23:00           ` Dave Chinner
2013-12-10 20:11 ` [PATCH 07/10] xfstests: fix generic/127 to call _cleanup() only once Junho Ryu
2013-12-11  7:47   ` Christoph Hellwig
2013-12-10 20:11 ` [PATCH 08/10] xfstests: check O_DIRECT support before testing direct I/O Junho Ryu
2013-12-11  7:47   ` Christoph Hellwig
2013-12-10 20:12 ` [PATCH 09/10] xfstests: add executable permission to tests Junho Ryu
2013-12-11  7:48   ` Christoph Hellwig
2013-12-10 20:12 ` [PATCH 10/10] xfstests: skip parts of tests which cannot work on tmpfs Junho Ryu
2013-12-11  7:51   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131212001655.GA31768@thunk.org \
    --to=tytso@mit.edu \
    --cc=branto@redhat.com \
    --cc=david@fromorbit.com \
    --cc=hch@infradead.org \
    --cc=hughd@google.com \
    --cc=jayr@google.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox