public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: tytso@mit.edu, Junho Ryu <jayr@google.com>,
	hughd@google.com, xfs@oss.sgi.com,
	Christoph Hellwig <hch@infradead.org>,
	branto@redhat.com
Subject: Re: [PATCH 05/10] xfstests: do not unmount tmpfs during remount.
Date: Thu, 12 Dec 2013 10:01:30 -0800	[thread overview]
Message-ID: <20131212180130.GA19422@infradead.org> (raw)
In-Reply-To: <20131211224012.GJ10988@dastard>

On Thu, Dec 12, 2013 at 09:40:12AM +1100, Dave Chinner wrote:
> IOWs, adding tmpfs changes the definition of a "generic" test.
> 
> i.e. instead of:
> 
> _supported_fs generic
> 
> these tests are now:
> 
> _supported_fs xfs ext2 ext3 ext4 ext4dev btrfs gfs2 nfs udf reiserfs
> 
> and by that definition should be in the tests/shared directory....
> 
> That's a bit of a pain, but I really don't like the idea of having
> "generic" tests that aren't actually generic by having to define
> exceptions for them...

We already have tons of these:

tests/generic/079:    _notrun "Setting immutable/append flag not supported"
tests/generic/192:      _notrun "this test makes no sense with noatime"
tests/generic/225:            _notrun "FIEMAP not supported by this filesystem type: $FSTYP"
tests/generic/251:_test_batched_discard $SCRATCH_MNT || _notrun "FITRIM not supported on $SCRATCH_DEV"
tests/generic/260:_test_batched_discard $SCRATCH_MNT || _notrun "FITRIM not supported on $SCRATCH_DEV"
tests/generic/288:_test_batched_discard $SCRATCH_MNT || _notrun "FITRIM
 not supported on $SCRATCH_DEV"


tests/generic/053:_require_acls
tests/generic/077:_require_acls
tests/generic/099:_require_acls
tests/generic/105:_require_acls
tests/generic/237:_require_acls
tests/generic/314:_require_acls
tests/generic/318:_require_acls
tests/generic/319:_require_acls

tests/generic/020:_require_attrs
tests/generic/062:_require_attrs
tests/generic/070:_require_attrs
tests/generic/077:_require_attrs
tests/generic/079:_require_attrs
tests/generic/093:_require_attrs
tests/generic/097:_require_attrs
tests/generic/117:_require_attrs

tests/generic/213:_require_xfs_io_falloc
tests/generic/214:_require_xfs_io_falloc
tests/generic/223:_require_xfs_io_falloc
tests/generic/228:_require_xfs_io_falloc
tests/generic/255:_require_xfs_io_falloc_punch
tests/generic/255:_require_xfs_io_falloc
tests/generic/256:_require_xfs_io_falloc_punch
tests/generic/274:_require_xfs_io_falloc
tests/generic/312:_require_xfs_io_falloc
tests/generic/316:_require_xfs_io_falloc_punch

tests/generic/068:_require_freeze
tests/generic/280:_require_freezeA

tests/generic/219:_require_quota
tests/generic/230:_require_quota
tests/generic/231:_require_quota
tests/generic/232:_require_quota
tests/generic/233:_require_quota
tests/generic/234:_require_quota
tests/generic/235:_require_quota
tests/generic/270:_require_quota
tests/generic/280:_require_quota

tests/generic/285:_require_seek_data_hole
tests/generic/286:_require_seek_data_hole

tests/generic/014:_require_sparse_files
tests/generic/129:_require_sparse_files
tests/generic/130:_require_sparse_files
tests/generic/239:_require_sparse_files
tests/generic/240:_require_sparse_files

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  parent reply	other threads:[~2013-12-12 18:01 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-10 20:11 [PATCH 00/10] Add tmpfs filesystem support Junho Ryu
2013-12-10 20:11 ` [PATCH 01/10] xfstests: Add tmpfs support Junho Ryu
2013-12-11  7:40   ` Christoph Hellwig
2013-12-17 16:40   ` Rich Johnston
2013-12-10 20:11 ` [PATCH 02/10] xfstests: use mount point instead of device name Junho Ryu
2013-12-11  7:42   ` Christoph Hellwig
2013-12-10 20:11 ` [PATCH 03/10] xfstests: _scratch_mkfs_sized() for tmpfs Junho Ryu
2013-12-11  7:44   ` Christoph Hellwig
2013-12-10 20:11 ` [PATCH 04/10] xfstests: increase tmpfs memory size Junho Ryu
2013-12-11  7:44   ` Christoph Hellwig
2013-12-10 20:11 ` [PATCH 05/10] xfstests: do not unmount tmpfs during remount Junho Ryu
2013-12-11  7:46   ` Christoph Hellwig
2013-12-11 22:40     ` Dave Chinner
2013-12-12  0:16       ` Theodore Ts'o
2013-12-12  0:53         ` Dave Chinner
2013-12-12 18:01       ` Christoph Hellwig [this message]
2013-12-12 22:56         ` Dave Chinner
2013-12-13  0:00           ` Junho Ryu
2013-12-13  1:41             ` Dave Chinner
2013-12-13 11:12               ` Christoph Hellwig
2013-12-13  4:56           ` Theodore Ts'o
2013-12-13 11:04           ` Christoph Hellwig
2013-12-10 20:11 ` [PATCH 06/10] xfstests: fix generic/225 to check fiemap support Junho Ryu
2013-12-11  7:46   ` Christoph Hellwig
2013-12-11 22:42     ` Dave Chinner
2013-12-12 18:01       ` Christoph Hellwig
2013-12-12 22:44         ` Junho Ryu
2013-12-12 23:00           ` Dave Chinner
2013-12-10 20:11 ` [PATCH 07/10] xfstests: fix generic/127 to call _cleanup() only once Junho Ryu
2013-12-11  7:47   ` Christoph Hellwig
2013-12-10 20:11 ` [PATCH 08/10] xfstests: check O_DIRECT support before testing direct I/O Junho Ryu
2013-12-11  7:47   ` Christoph Hellwig
2013-12-10 20:12 ` [PATCH 09/10] xfstests: add executable permission to tests Junho Ryu
2013-12-11  7:48   ` Christoph Hellwig
2013-12-10 20:12 ` [PATCH 10/10] xfstests: skip parts of tests which cannot work on tmpfs Junho Ryu
2013-12-11  7:51   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131212180130.GA19422@infradead.org \
    --to=hch@infradead.org \
    --cc=branto@redhat.com \
    --cc=david@fromorbit.com \
    --cc=hughd@google.com \
    --cc=jayr@google.com \
    --cc=tytso@mit.edu \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox