From: Dave Chinner <david@fromorbit.com>
To: Jeff Liu <jeff.liu@oracle.com>
Cc: "xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [PATCH v2 5/8] xfs: use xfs_icluster_size_fsb in xfs_bulkstat
Date: Fri, 13 Dec 2013 09:18:26 +1100 [thread overview]
Message-ID: <20131212221826.GH10988@dastard> (raw)
In-Reply-To: <52A96800.5080706@oracle.com>
On Thu, Dec 12, 2013 at 03:38:40PM +0800, Jeff Liu wrote:
> From: Jie Liu <jeff.liu@oracle.com>
>
> Use xfs_icluster_size_fsb() in xfs_bulkstat(), make the related
> variables more meaningful and remove an unused variable nimask
> from it.
>
> Signed-off-by: Jie Liu <jeff.liu@oracle.com>
Looks fine.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
At some point we need to factor this code a bit to get rid of the
levels of indenting it has.....
> @@ -390,12 +386,12 @@ xfs_bulkstat(
> agbno = XFS_AGINO_TO_AGBNO(mp, r.ir_startino);
> for (chunkidx = 0;
> chunkidx < XFS_INODES_PER_CHUNK;
> - chunkidx += nicluster,
> - agbno += nbcluster) {
> - if (xfs_inobt_maskn(chunkidx, nicluster)
> - & ~r.ir_free)
> + chunkidx += inodes_per_cluster,
> + agbno += blks_per_cluster) {
> + if (xfs_inobt_maskn(chunkidx,
> + inodes_per_cluster) & ~r.ir_free)
> xfs_btree_reada_bufs(mp, agno,
> - agbno, nbcluster,
> + agbno, blks_per_cluster,
> &xfs_inode_buf_ops);
> }
> blk_finish_plug(&plug);
e.g. this readahead loop could be factored into
static void
xfs_ichunk_ra(
*mp, *rec, inodes_per_cluster, blks_per_cluster)
{
blk_start_plug(&plug);
agbno = XFS_AGINO_TO_AGBNO(mp, r.ir_startino);
for (chunkidx = 0; chunkidx < XFS_INODES_PER_CHUNK;
chunkidx += inodes_per_cluster, agbno += blks_per_cluster) {
if (xfs_inobt_maskn(chunkidx, inodes_per_cluster) & ~r.ir_free)
xfs_btree_reada_bufs(mp, agno, agbno, blks_per_cluster,
&xfs_inode_buf_ops);
}
blk_finish_plug(&plug);
}
Doing this to all the separate parts of the bulkstat code would make
it an awful lot easier to read and modify in future....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-12-12 22:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-12 7:38 [PATCH v2 5/8] xfs: use xfs_icluster_size_fsb in xfs_bulkstat Jeff Liu
2013-12-12 22:18 ` Dave Chinner [this message]
2013-12-13 2:20 ` Jeff Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131212221826.GH10988@dastard \
--to=david@fromorbit.com \
--cc=jeff.liu@oracle.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox