From: Dave Chinner <david@fromorbit.com>
To: Jeff Liu <jeff.liu@oracle.com>
Cc: "xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [PATCH v2 0/8] xfs: Introduce a common helper to calculate the number of blocks per cluster
Date: Fri, 13 Dec 2013 09:19:52 +1100 [thread overview]
Message-ID: <20131212221951.GI10988@dastard> (raw)
In-Reply-To: <52A967C6.1050303@oracle.com>
On Thu, Dec 12, 2013 at 03:37:42PM +0800, Jeff Liu wrote:
> Hi Folks,
>
> Here is the v2 patch series to introduce a common helper which could be used
> to calculate the number of file system blocks in an inode cluster.
>
> v2->v1:
> * Rename xfs_ialloc_blks_per_cluster() to xfs_icluster_size_fsb() as per dave's
> suggestion.
> * Remove three macros XFS_IALLOC_INODES/XFS_INODE_CLUSTER_SIZE/XFS_IALLOC_BLOCKS
> separately as preparation steps.
> * s/ninodes/inodes_per_cluster/g, as the later is more meaningful.
> * Remove wrong commit notes I previously written for using xfs_ialloc_blks_per_cluster
> in xfs_imap().
All looks good, Jeff. Nice work, and thanks for adding all the extra
cleanups to it :)
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-12-12 22:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-12 7:37 [PATCH v2 0/8] xfs: Introduce a common helper to calculate the number of blocks per cluster Jeff Liu
2013-12-12 22:19 ` Dave Chinner [this message]
2013-12-13 11:15 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131212221951.GI10988@dastard \
--to=david@fromorbit.com \
--cc=jeff.liu@oracle.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox