From: Dave Chinner <david@fromorbit.com>
To: Junho Ryu <jayr@google.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Theodore Ts'o <tytso@mit.edu>, Hugh Dickins <hughd@google.com>,
Boris Ranto <branto@redhat.com>,
xfs@oss.sgi.com
Subject: Re: [PATCH 05/10] xfstests: do not unmount tmpfs during remount.
Date: Fri, 13 Dec 2013 12:41:31 +1100 [thread overview]
Message-ID: <20131213014131.GP10988@dastard> (raw)
In-Reply-To: <CAFA30n9ea3A+V7JgCgqO5xOQchgB55oLP4AgtQ3KQpCMr9iEzQ@mail.gmail.com>
On Thu, Dec 12, 2013 at 04:00:44PM -0800, Junho Ryu wrote:
> > I don't know what the solution here is - everything I think of is
> > either messy, ugly or unmaintainable. All I'm trying to do is find a
> > way to handle tmpfs filesystems in a way that is maintainable and
> > doesn't require every developer to be aware of the quirks of tmpfs
> > when writing and reviewing new generic tests....
>
> If it is acceptable that tmpfs running tests which does not make much
> sense without actually re-mounting devices, all other developers need
> to care is using _scratch_remount() and _test_remount().
And how are they to know whether it makes sense ot run on tmpfs or
not? That's the point I'm trying to make - tmpfs adds new
restrictions on how tests are written or constructed, and we still
need a method of saying no to tmpfs....
> Even if someone does not use the functions, tests will only fail on
> tmpfs, and people like me who cares about it will be happy to fix it.
Yes, that's the game of whack-a-mole I was talking about.
> So far, generic/053 is the only test which does something else between
> umount and mount.
All the generic tests that use dm_flakey are likely to be busted.
Anything assumes SCRATCH_DEV or TEST_DEV are block devices are
busted. Do loop devices work properly when hosted on tmpfs
filesystems? And so on...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-12-13 1:42 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-10 20:11 [PATCH 00/10] Add tmpfs filesystem support Junho Ryu
2013-12-10 20:11 ` [PATCH 01/10] xfstests: Add tmpfs support Junho Ryu
2013-12-11 7:40 ` Christoph Hellwig
2013-12-17 16:40 ` Rich Johnston
2013-12-10 20:11 ` [PATCH 02/10] xfstests: use mount point instead of device name Junho Ryu
2013-12-11 7:42 ` Christoph Hellwig
2013-12-10 20:11 ` [PATCH 03/10] xfstests: _scratch_mkfs_sized() for tmpfs Junho Ryu
2013-12-11 7:44 ` Christoph Hellwig
2013-12-10 20:11 ` [PATCH 04/10] xfstests: increase tmpfs memory size Junho Ryu
2013-12-11 7:44 ` Christoph Hellwig
2013-12-10 20:11 ` [PATCH 05/10] xfstests: do not unmount tmpfs during remount Junho Ryu
2013-12-11 7:46 ` Christoph Hellwig
2013-12-11 22:40 ` Dave Chinner
2013-12-12 0:16 ` Theodore Ts'o
2013-12-12 0:53 ` Dave Chinner
2013-12-12 18:01 ` Christoph Hellwig
2013-12-12 22:56 ` Dave Chinner
2013-12-13 0:00 ` Junho Ryu
2013-12-13 1:41 ` Dave Chinner [this message]
2013-12-13 11:12 ` Christoph Hellwig
2013-12-13 4:56 ` Theodore Ts'o
2013-12-13 11:04 ` Christoph Hellwig
2013-12-10 20:11 ` [PATCH 06/10] xfstests: fix generic/225 to check fiemap support Junho Ryu
2013-12-11 7:46 ` Christoph Hellwig
2013-12-11 22:42 ` Dave Chinner
2013-12-12 18:01 ` Christoph Hellwig
2013-12-12 22:44 ` Junho Ryu
2013-12-12 23:00 ` Dave Chinner
2013-12-10 20:11 ` [PATCH 07/10] xfstests: fix generic/127 to call _cleanup() only once Junho Ryu
2013-12-11 7:47 ` Christoph Hellwig
2013-12-10 20:11 ` [PATCH 08/10] xfstests: check O_DIRECT support before testing direct I/O Junho Ryu
2013-12-11 7:47 ` Christoph Hellwig
2013-12-10 20:12 ` [PATCH 09/10] xfstests: add executable permission to tests Junho Ryu
2013-12-11 7:48 ` Christoph Hellwig
2013-12-10 20:12 ` [PATCH 10/10] xfstests: skip parts of tests which cannot work on tmpfs Junho Ryu
2013-12-11 7:51 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131213014131.GP10988@dastard \
--to=david@fromorbit.com \
--cc=branto@redhat.com \
--cc=hch@infradead.org \
--cc=hughd@google.com \
--cc=jayr@google.com \
--cc=tytso@mit.edu \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox