Re: [PATCH 02/10] xfstests: use mount point instead of device name

Christoph Hellwig
2013-12-11T07:42:58Z

On Tue, Dec 10, 2013 at 12:11:53PM -0800, Junho Ryu wrote:
> From: Hugh Dickins <hughd@google.com>
>
> A tmpfs mount does not involve any block device, its $SCRATCH_DEV is
> nothing but a place-holder, so apply 'df' or 'stat' to its mount point
> $SCRATCH_MNT instead of to $SCRATCH_DEV.
>
> It also fixes a bug in generic/256: "stat -f $SCRATCH_DEV" returning the
> block size of the root file system, but not the test file system.
>
> $ df | grep sda
> /dev/sda1 233191 62959 157791 29% /boot
>
> $ sudo dumpe2fs -h /dev/sda1 | grep "Block size"
> Block size: 1024
>
> $ stat -f /dev/sda1 | grep "Block size"
> Block size: 4096 Fundamental block size: 4096
>
> $ stat -f /boot | grep "Block size"
> Block size: 1024 Fundamental block size: 1024
>
> Signed-off-by: Hugh Dickins <hughd@google.com>
> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
> Signed-off-by: Junho Ryu <jayr@google.com>

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

Although I have to wonder how you got these tests to run, as it seems
like you didn't implement _scratch_mkfs_sized for tmpfs.