From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Stanislav Kholmanskikh <stanislav.kholmanskikh@oracle.com>,
xfs@oss.sgi.com
Subject: Re: [PATCH 00/12] run more generic tests on TEST_DIR
Date: Fri, 13 Dec 2013 03:10:39 -0800 [thread overview]
Message-ID: <20131213111039.GD14884@infradead.org> (raw)
In-Reply-To: <20131213010934.GN10988@dastard>
On Fri, Dec 13, 2013 at 12:09:34PM +1100, Dave Chinner wrote:
> > You can have different test devices, or simply not bother with aging
> > it for every run. You're missing the coverage of all the test dir
> > using tests, which are a lot with the above version anyway.
>
> IOWs, you're saying that you don't consider MKFS_OPTIONS as a first
> class citizen. I've been using it for 7 or 8 years for exactly this
> purpose - iterating testing of a change quickly across multiple
> configurations without perturbing the long term aging of the test
> device.
But you're limiting yourself to the tests only using the scratch
device for that testing, leaving out all the ones using the TEST
directory.
> I'm not opposed to making the change, just pointing out that
> reducing the usage of the scratch device has a fairly significant
> impact on test coverage for anyone who uses MKFS_OPTIONS in their
> workflow...
It does have an impact for that particular workload, but I think that
workload is broken as you only test your specific config for those
tests using the scratch device, and do not get the coverage for the
tests using the test device.
git-grep -l TEST_DIR tests/generic/ | grep -v out | wc -l
65
git-grep -l TEST_DIR tests/xfs/ | grep -v out | wc -l
23
hch@brick:~/work/xfstests$ git-grep -l _require_scratch tests/generic/ | wc -l
58
hch@brick:~/work/xfstests$ git-grep -l _require_scratch tests/xfs/ | wc -l
128
So you're missing close to 2/3s of the tests already.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-12-13 11:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-11 7:34 [PATCH 00/12] run more generic tests on TEST_DIR Christoph Hellwig
2013-12-11 7:34 ` [PATCH 01/12] 062: use TEST_DIR instead of a SCRATCH_DEV Christoph Hellwig
2013-12-11 7:34 ` [PATCH 02/12] 069: " Christoph Hellwig
2013-12-11 7:34 ` [PATCH 03/12] 079: " Christoph Hellwig
2013-12-11 7:34 ` [PATCH 04/12] 100: " Christoph Hellwig
2013-12-11 7:34 ` [PATCH 05/12] 105: " Christoph Hellwig
2013-12-11 7:34 ` [PATCH 06/12] 117: " Christoph Hellwig
2013-12-11 7:34 ` [PATCH 07/12] 124: " Christoph Hellwig
2013-12-11 7:34 ` [PATCH 08/12] 130: " Christoph Hellwig
2013-12-11 7:34 ` [PATCH 09/12] 132: " Christoph Hellwig
2013-12-11 7:34 ` [PATCH 10/12] 141: " Christoph Hellwig
2013-12-11 7:34 ` [PATCH 11/12] 225: " Christoph Hellwig
2013-12-11 7:34 ` [PATCH 12/12] 319: " Christoph Hellwig
2013-12-11 22:50 ` [PATCH 00/12] run more generic tests on TEST_DIR Dave Chinner
[not found] ` <20131212180312.GC19422@infradead.org>
2013-12-13 1:09 ` Dave Chinner
2013-12-13 11:10 ` Christoph Hellwig [this message]
2013-12-17 21:19 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131213111039.GD14884@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=stanislav.kholmanskikh@oracle.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox