From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id E61227F52 for ; Fri, 13 Dec 2013 17:01:51 -0600 (CST) Received: from whiskey.americas.sgi.com (whiskey.americas.sgi.com [128.162.233.19]) by relay2.corp.sgi.com (Postfix) with ESMTP id D0181304039 for ; Fri, 13 Dec 2013 15:01:39 -0800 (PST) Date: Fri, 13 Dec 2013 17:01:06 -0600 From: Ben Myers Subject: Re: [PATCH] xfs: require 64-bit sector_t Message-ID: <20131213230106.GN1935@sgi.com> References: <20131114164603.GA13628@infradead.org> <20131213213701.GM1935@sgi.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20131213213701.GM1935@sgi.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Christoph Hellwig Cc: xfs@oss.sgi.com Hey, On Fri, Dec 13, 2013 at 03:37:01PM -0600, Ben Myers wrote: > On Thu, Nov 14, 2013 at 08:46:03AM -0800, Christoph Hellwig wrote: > > Trying to support tiny disks only and saving a bit memory might have > > made sense on an SGI O2 15 years ago, but is pretty pointless today. > > > > Remove the rarely tested codepath that uses various smaller in-memory > > types to reduce our test matrix and make the codebase a little bit > > smaller and less complicated. > > > > > > Signed-off-by: Christoph Hellwig > > > > diff --git a/fs/xfs/Kconfig b/fs/xfs/Kconfig > > index 399e8ce..5d47b4d 100644 > > --- a/fs/xfs/Kconfig > > +++ b/fs/xfs/Kconfig > > @@ -1,6 +1,7 @@ > > config XFS_FS > > tristate "XFS filesystem support" > > depends on BLOCK > > + depends on (64BIT || LBDAF) > > There are quite a few 32 bit arches in use today. We need to continue to > support them in XFS as long as they are supported by the kernel. Unless I have > misunderstood what you are suggesting, I believe the answer to this patch must > be a firm 'no'. I stepped away for a few minutes and realized my mistake. ;/ Apologies! I'll take another look at the rest of the patch. Thanks, Ben _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs