From: Dave Chinner <david@fromorbit.com>
To: arno <arno@disconnect.de>
Cc: linux-kernel@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [XFS BUG] xfs_growfs: XFS_IOC_FSGROWFSDATA xfsctl failed: Structure needs cleaning
Date: Thu, 19 Dec 2013 09:33:13 +1100 [thread overview]
Message-ID: <20131218223312.GP31386@dastard> (raw)
In-Reply-To: <52B1B89A.8030401@disconnect.de>
On Wed, Dec 18, 2013 at 04:00:42PM +0100, arno wrote:
> Hello,
>
> (Please keep me in CC, I'm not subscribed)
>
> Just got "xfs_growfs: XFS_IOC_FSGROWFSDATA xfsctl failed: Structure
> needs cleaning" when trying to grow a logical Volume. Sorry, I lost the
> xfs_growfs output.
>
> After collecting some info, I ran xfs_repair, and that seemed to fix it,
> so no harm done. After fixing, the FS had the new, increased size, if
> that matters.
This isn't the first time you've grown the filesystem, is it?
On older kernels, growfs could leave trailing garbage in the new
secondary superblocks it created. This was fixed in kernel v3.8 by
commit:
1375cb6 xfs: growfs: don't read garbage for new secondary superblocks
This garbage is detected by other changes made in v3.8 that verify
the secondary superblocks as they are read.
9802182 xfs: verify superblocks as they are read from disk
So if you grew the filesystem on a kernel older than v3.8, growing
it again on a v3.8+ kernel will detect the superblock corruption and
throw this error.
xfs_repair was recently fixed to detect the garbage in secondary
superblocks and zero it:
cbd7508 xfs_repair: zero out unused parts of superblocks
So what you need to do is run xfs_repair built from the development
git tree and run it on your filesystem. That will remove the garbage
from the superblocks and make this problem go away forever.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-12-18 22:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-18 15:00 [XFS BUG] xfs_growfs: XFS_IOC_FSGROWFSDATA xfsctl failed: Structure needs cleaning arno
2013-12-18 22:33 ` Dave Chinner [this message]
2013-12-19 8:02 ` arno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131218223312.GP31386@dastard \
--to=david@fromorbit.com \
--cc=arno@disconnect.de \
--cc=linux-kernel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).