linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] xfstests: UDF support improvements
@ 2013-12-23 22:53 Jan Kara
  2013-12-23 22:53 ` [PATCH 1/2] Fix output parsing in _check_udf_filesystem() Jan Kara
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Jan Kara @ 2013-12-23 22:53 UTC (permalink / raw)
  To: xfs


  Hello,

  below are two patches which improve UDF support in xfstests.

								Honza

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/2] Fix output parsing in _check_udf_filesystem()
  2013-12-23 22:53 [PATCH 0/2] xfstests: UDF support improvements Jan Kara
@ 2013-12-23 22:53 ` Jan Kara
  2013-12-23 22:53 ` [PATCH 2/2] Add udf support into _scratch_mkfs_sized Jan Kara
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Jan Kara @ 2013-12-23 22:53 UTC (permalink / raw)
  To: xfs; +Cc: Jan Kara

Move of tests into separate subdirectories broke sed(1) expression in
_check_udf_filesystem(). Actually use of sed in that place was rather
stupid so just replace it with plain echo.

Signed-off-by: Jan Kara <jack@suse.cz>
---
 common/rc | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/common/rc b/common/rc
index fe6bbfcbfc55..12f0196655a8 100644
--- a/common/rc
+++ b/common/rc
@@ -1582,9 +1582,8 @@ _check_udf_filesystem()
     sleep 1 # Due to a problem with time stamps in udf_test
     $here/src/udf_test $OPT_ARG $device | tee $seqres.checkfs | egrep "Error|Warning" | \
 	_udf_test_known_error_filter | \
-	egrep -iv "Error count:.*[0-9]+.*total occurrences:.*[0-9]+|Warning count:.*[0-9]+.*total occurrences:.*[0-9]+" | \
-	sed "s/^.*$/Warning UDF Verifier reported errors see $seqres.checkfs./g"
-
+	egrep -iv "Error count:.*[0-9]+.*total occurrences:.*[0-9]+|Warning count:.*[0-9]+.*total occurrences:.*[0-9]+" && \
+        echo "Warning UDF Verifier reported errors see $seqres.checkfs."
 }
 
 _check_xfs_test_fs()
-- 
1.8.1.4

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/2] Add udf support into _scratch_mkfs_sized
  2013-12-23 22:53 [PATCH 0/2] xfstests: UDF support improvements Jan Kara
  2013-12-23 22:53 ` [PATCH 1/2] Fix output parsing in _check_udf_filesystem() Jan Kara
@ 2013-12-23 22:53 ` Jan Kara
  2014-01-06 17:41 ` [PATCH 0/2] xfstests: UDF support improvements Ben Myers
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Jan Kara @ 2013-12-23 22:53 UTC (permalink / raw)
  To: xfs; +Cc: Jan Kara

Signed-off-by: Jan Kara <jack@suse.cz>
---
 common/rc | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/common/rc b/common/rc
index 12f0196655a8..22cd975b3fe8 100644
--- a/common/rc
+++ b/common/rc
@@ -563,6 +563,9 @@ _scratch_mkfs_sized()
     ext2|ext3|ext4|ext4dev)
 	yes | ${MKFS_PROG}.$FSTYP $MKFS_OPTIONS -b $blocksize $SCRATCH_DEV $blocks
 	;;
+    udf)
+	$MKFS_UDF_PROG $MKFS_OPTIONS -b $blocksize $SCRATCH_DEV $blocks
+	;;
     btrfs)
 	$MKFS_BTRFS_PROG $MKFS_OPTIONS -b $fssize $SCRATCH_DEV
 	;;
-- 
1.8.1.4

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/2] xfstests: UDF support improvements
  2013-12-23 22:53 [PATCH 0/2] xfstests: UDF support improvements Jan Kara
  2013-12-23 22:53 ` [PATCH 1/2] Fix output parsing in _check_udf_filesystem() Jan Kara
  2013-12-23 22:53 ` [PATCH 2/2] Add udf support into _scratch_mkfs_sized Jan Kara
@ 2014-01-06 17:41 ` Ben Myers
  2014-01-08 11:43 ` Carlos Maiolino
  2014-01-08 13:30 ` Rich Johnston
  4 siblings, 0 replies; 6+ messages in thread
From: Ben Myers @ 2014-01-06 17:41 UTC (permalink / raw)
  To: Jan Kara; +Cc: xfs

On Mon, Dec 23, 2013 at 11:53:49PM +0100, Jan Kara wrote:
> 
>   Hello,
> 
>   below are two patches which improve UDF support in xfstests.

Both look good to me.

Reviewed-by: Ben Myers <bpm@sgi.com>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/2] xfstests: UDF support improvements
  2013-12-23 22:53 [PATCH 0/2] xfstests: UDF support improvements Jan Kara
                   ` (2 preceding siblings ...)
  2014-01-06 17:41 ` [PATCH 0/2] xfstests: UDF support improvements Ben Myers
@ 2014-01-08 11:43 ` Carlos Maiolino
  2014-01-08 13:30 ` Rich Johnston
  4 siblings, 0 replies; 6+ messages in thread
From: Carlos Maiolino @ 2014-01-08 11:43 UTC (permalink / raw)
  To: xfs

Looks good to me

Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>


On Mon, Dec 23, 2013 at 11:53:49PM +0100, Jan Kara wrote:
> 
>   Hello,
> 
>   below are two patches which improve UDF support in xfstests.
> 
> 								Honza
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs

-- 
Carlos

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/2] xfstests: UDF support improvements
  2013-12-23 22:53 [PATCH 0/2] xfstests: UDF support improvements Jan Kara
                   ` (3 preceding siblings ...)
  2014-01-08 11:43 ` Carlos Maiolino
@ 2014-01-08 13:30 ` Rich Johnston
  4 siblings, 0 replies; 6+ messages in thread
From: Rich Johnston @ 2014-01-08 13:30 UTC (permalink / raw)
  To: Jan Kara, xfs

This series has been committed.

Thanks
--Rich

commit 7e4cac452bf38ee4ace80b60efca7f6318b88eea
Author: Jan Kara <jack@suse.cz>
Date:   Mon Dec 23 22:53:51 2013 +0000

     Add udf support into _scratch_mkfs_sized

commit 49684caded92f23dd18ec4698917e087f23a9016
Author: Jan Kara <jack@suse.cz>
Date:   Mon Dec 23 22:53:50 2013 +0000

     Fix output parsing in _check_udf_filesystem()


_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2014-01-08 13:30 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-23 22:53 [PATCH 0/2] xfstests: UDF support improvements Jan Kara
2013-12-23 22:53 ` [PATCH 1/2] Fix output parsing in _check_udf_filesystem() Jan Kara
2013-12-23 22:53 ` [PATCH 2/2] Add udf support into _scratch_mkfs_sized Jan Kara
2014-01-06 17:41 ` [PATCH 0/2] xfstests: UDF support improvements Ben Myers
2014-01-08 11:43 ` Carlos Maiolino
2014-01-08 13:30 ` Rich Johnston

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).