* [PATCH 2/3] xfs: Calling destroy_work_on_stack() to pair with INIT_WORK_ONSTACK() [not found] <1389084605.3650.66.camel@cliu38-desktop-build> @ 2014-01-07 8:53 ` Chuansheng Liu 2014-01-07 11:21 ` Jeff Liu 0 siblings, 1 reply; 4+ messages in thread From: Chuansheng Liu @ 2014-01-07 8:53 UTC (permalink / raw) To: dchinner, bpm; +Cc: chuansheng.liu, linux-kernel, xfs In case CONFIG_DEBUG_OBJECTS_WORK is defined, it is needed to call destroy_work_on_stack() which frees the debug object to pair with INIT_WORK_ONSTACK(). Signed-off-by: Liu, Chuansheng <chuansheng.liu@intel.com> --- fs/xfs/xfs_bmap_util.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/xfs/xfs_bmap_util.c b/fs/xfs/xfs_bmap_util.c index 1394106..82e0dab 100644 --- a/fs/xfs/xfs_bmap_util.c +++ b/fs/xfs/xfs_bmap_util.c @@ -287,6 +287,7 @@ xfs_bmapi_allocate( INIT_WORK_ONSTACK(&args->work, xfs_bmapi_allocate_worker); queue_work(xfs_alloc_wq, &args->work); wait_for_completion(&done); + destroy_work_on_stack(&args->work); return args->result; } -- 1.7.9.5 _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 2/3] xfs: Calling destroy_work_on_stack() to pair with INIT_WORK_ONSTACK() 2014-01-07 8:53 ` [PATCH 2/3] xfs: Calling destroy_work_on_stack() to pair with INIT_WORK_ONSTACK() Chuansheng Liu @ 2014-01-07 11:21 ` Jeff Liu 2014-01-07 19:34 ` Ben Myers 2014-01-08 0:57 ` Liu, Chuansheng 0 siblings, 2 replies; 4+ messages in thread From: Jeff Liu @ 2014-01-07 11:21 UTC (permalink / raw) To: Chuansheng Liu, dchinner, bpm; +Cc: linux-kernel, xfs Hi Chuansheng, On 01/07 2014 16:53 PM, Chuansheng Liu wrote: > > In case CONFIG_DEBUG_OBJECTS_WORK is defined, it is needed to > call destroy_work_on_stack() which frees the debug object to pair > with INIT_WORK_ONSTACK(). > > Signed-off-by: Liu, Chuansheng <chuansheng.liu@intel.com> > --- > fs/xfs/xfs_bmap_util.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/xfs/xfs_bmap_util.c b/fs/xfs/xfs_bmap_util.c > index 1394106..82e0dab 100644 > --- a/fs/xfs/xfs_bmap_util.c > +++ b/fs/xfs/xfs_bmap_util.c > @@ -287,6 +287,7 @@ xfs_bmapi_allocate( > INIT_WORK_ONSTACK(&args->work, xfs_bmapi_allocate_worker); > queue_work(xfs_alloc_wq, &args->work); > wait_for_completion(&done); > + destroy_work_on_stack(&args->work); > return args->result; > } Thanks for your patch and it work fine for my testing. I missed this in an old commit: [ 3b876c8f2a xfs: fix debug_object WARN at xfs_alloc_vextent() ] Just out of curious, do you notice memory leaks or other hints which help you finding out this problem? Thanks, -Jeff _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/3] xfs: Calling destroy_work_on_stack() to pair with INIT_WORK_ONSTACK() 2014-01-07 11:21 ` Jeff Liu @ 2014-01-07 19:34 ` Ben Myers 2014-01-08 0:57 ` Liu, Chuansheng 1 sibling, 0 replies; 4+ messages in thread From: Ben Myers @ 2014-01-07 19:34 UTC (permalink / raw) To: Jeff Liu, Chuansheng Liu; +Cc: dchinner, linux-kernel, xfs On Tue, Jan 07, 2014 at 07:21:05PM +0800, Jeff Liu wrote: > Hi Chuansheng, > > On 01/07 2014 16:53 PM, Chuansheng Liu wrote: > > > > In case CONFIG_DEBUG_OBJECTS_WORK is defined, it is needed to > > call destroy_work_on_stack() which frees the debug object to pair > > with INIT_WORK_ONSTACK(). > > > > Signed-off-by: Liu, Chuansheng <chuansheng.liu@intel.com> > > --- > > fs/xfs/xfs_bmap_util.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/fs/xfs/xfs_bmap_util.c b/fs/xfs/xfs_bmap_util.c > > index 1394106..82e0dab 100644 > > --- a/fs/xfs/xfs_bmap_util.c > > +++ b/fs/xfs/xfs_bmap_util.c > > @@ -287,6 +287,7 @@ xfs_bmapi_allocate( > > INIT_WORK_ONSTACK(&args->work, xfs_bmapi_allocate_worker); > > queue_work(xfs_alloc_wq, &args->work); > > wait_for_completion(&done); > > + destroy_work_on_stack(&args->work); > > return args->result; > > } > > Thanks for your patch and it work fine for my testing. I missed this in an > old commit: [ 3b876c8f2a xfs: fix debug_object WARN at xfs_alloc_vextent() ] Looks good to me too. Reviewed-by: Ben Myers <bpm@sgi.com> _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs ^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH 2/3] xfs: Calling destroy_work_on_stack() to pair with INIT_WORK_ONSTACK() 2014-01-07 11:21 ` Jeff Liu 2014-01-07 19:34 ` Ben Myers @ 2014-01-08 0:57 ` Liu, Chuansheng 1 sibling, 0 replies; 4+ messages in thread From: Liu, Chuansheng @ 2014-01-08 0:57 UTC (permalink / raw) To: Jeff Liu, dchinner@redhat.com, bpm@sgi.com Cc: linux-kernel@vger.kernel.org, xfs@oss.sgi.com Hello Jeff, > -----Original Message----- > From: Jeff Liu [mailto:jeff.liu@oracle.com] > Sent: Tuesday, January 07, 2014 7:21 PM > To: Liu, Chuansheng; dchinner@fromorbit.com; bpm@sgi.com > Cc: linux-kernel@vger.kernel.org; xfs@oss.sgi.com > Subject: Re: [PATCH 2/3] xfs: Calling destroy_work_on_stack() to pair with > INIT_WORK_ONSTACK() > > Hi Chuansheng, > > On 01/07 2014 16:53 PM, Chuansheng Liu wrote: > > > > In case CONFIG_DEBUG_OBJECTS_WORK is defined, it is needed to > > call destroy_work_on_stack() which frees the debug object to pair > > with INIT_WORK_ONSTACK(). > > > > Signed-off-by: Liu, Chuansheng <chuansheng.liu@intel.com> > > --- > Thanks for your patch and it work fine for my testing. I missed this in an > old commit: [ 3b876c8f2a xfs: fix debug_object WARN at xfs_alloc_vextent() ] Thanks your testing. > > Just out of curious, do you notice memory leaks or other hints which help you > finding out this problem? I am trying to use the INIT_WORK_ONSTACK() in my code, then I found in some places Calling destroy_work_on_stack() is missed. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-01-08 0:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1389084605.3650.66.camel@cliu38-desktop-build>
2014-01-07 8:53 ` [PATCH 2/3] xfs: Calling destroy_work_on_stack() to pair with INIT_WORK_ONSTACK() Chuansheng Liu
2014-01-07 11:21 ` Jeff Liu
2014-01-07 19:34 ` Ben Myers
2014-01-08 0:57 ` Liu, Chuansheng
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox