From: Dave Chinner <david@fromorbit.com>
To: David Sterba <dsterba@suse.cz>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 3/5] xfstests: don't suggest to run full diff when DIFF_LENGTH is 0
Date: Mon, 20 Jan 2014 13:25:14 +1100 [thread overview]
Message-ID: <20140120022514.GH18112@dastard> (raw)
In-Reply-To: <49b0cf305ade3444c3dcf3fbabb5e1e5e720c16d.1389891730.git.dsterba@suse.cz>
On Thu, Jan 16, 2014 at 06:07:13PM +0100, David Sterba wrote:
> If DIFF_LENGTH is set to 0, the full output is available and the message
> does not make sense.
>
> Signed-off-by: David Sterba <dsterba@suse.cz>
> ---
> check | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/check b/check
> index 9e4275b1fa37..d578e49b78d4 100755
> --- a/check
> +++ b/check
> @@ -510,11 +510,11 @@ do
> cat
> else
> head -n "$DIFF_LENGTH"
> + echo "..."
> + echo "(Run '$diff $seq.out $seqres.out.bad'"
> + " to see the entire diff)"
You're missing a trailing "\" there. Even simple patches need
testing. ;)
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-01-20 2:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-16 17:07 [PATCH 0/5] xfstests: A few updates to non-test code David Sterba
2014-01-16 17:07 ` [PATCH 1/5] xfstests: fix minor build warning David Sterba
2014-01-16 22:11 ` Ben Myers
2014-01-16 17:07 ` [PATCH 2/5] xfstests: use value of FSTYP if defined externally David Sterba
2014-01-20 2:13 ` Dave Chinner
2014-01-20 18:19 ` David Sterba
2014-01-20 22:22 ` Dave Chinner
2014-01-16 17:07 ` [PATCH 3/5] xfstests: don't suggest to run full diff when DIFF_LENGTH is 0 David Sterba
2014-01-20 2:25 ` Dave Chinner [this message]
2014-01-16 17:07 ` [PATCH 4/5] xfstests: accept tests/ prefix for test name on commandline David Sterba
2014-01-16 17:07 ` [PATCH 5/5] xfstests: update lsqa.pl for new tests layout David Sterba
2014-01-20 5:46 ` [PATCH 0/5] xfstests: A few updates to non-test code Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140120022514.GH18112@dastard \
--to=david@fromorbit.com \
--cc=dsterba@suse.cz \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox