Re: [PATCH 3/5] xfstests: don't suggest to run full diff when DIFF_LENGTH is 0

Dave Chinner
2014-01-20T02:25:22Z

On Thu, Jan 16, 2014 at 06:07:13PM +0100, David Sterba wrote:
> If DIFF_LENGTH is set to 0, the full output is available and the message
> does not make sense.
>
> Signed-off-by: David Sterba <dsterba@suse.cz>
> ---
> check | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/check b/check
> index 9e4275b1fa37..d578e49b78d4 100755
> --- a/check
> +++ b/check
> @@ -510,11 +510,11 @@ do
> cat
> else
> head -n "$DIFF_LENGTH"
> + echo "..."
> + echo "(Run '$diff $seq.out $seqres.out.bad'"
> + " to see the entire diff)"

You're missing a trailing "\" there. Even simple patches need
testing. ;)

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com