From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id 724147F58 for ; Mon, 27 Jan 2014 01:41:53 -0600 (CST) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay3.corp.sgi.com (Postfix) with ESMTP id 20C8DAC003 for ; Sun, 26 Jan 2014 23:41:53 -0800 (PST) Received: from bombadil.infradead.org ([198.137.202.9]) by cuda.sgi.com with ESMTP id Q7LZQhcdiQTCqsu3 (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO) for ; Sun, 26 Jan 2014 23:41:49 -0800 (PST) Date: Sun, 26 Jan 2014 23:41:47 -0800 From: Christoph Hellwig Subject: Re: [NOISE] merge window blues, XFS broken Message-ID: <20140127074147.GA13100@infradead.org> References: <52E56386.5040802@gmail.com> <20140127015614.GD2212@dastard> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20140127015614.GD2212@dastard> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: "Michael L. Semon" , xfs-oss On Mon, Jan 27, 2014 at 12:56:14PM +1100, Dave Chinner wrote: > Hmmmm - that would point to struct xfs_log_iovec being 12 bytes on > ia32, similarly the struct xfs_log_vec may not be 8 byte aligned > when allocated because pointers only require 4 byte alignement. > > Hence the initial data buffer may be 4 byte aligned and so that will > break the alignment requirement. Yeah. Shoulkd be enough to just align the initial lv_buf allocation. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs