From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 4/4] generic: inconsistent initial state for test_generic_punch
Date: Sun, 2 Feb 2014 23:40:05 -0800 [thread overview]
Message-ID: <20140203074005.GD16476@infradead.org> (raw)
In-Reply-To: <1391385365-12790-5-git-send-email-david@fromorbit.com>
On Mon, Feb 03, 2014 at 10:56:05AM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> The first test may start with the file from the previous test, and
> that is in an unknown state. Hence always remove the test file
> before the first test so that it doesn't have extents inside the
> test range as it is supposed to be testing into a hole.
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-02-03 7:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-02 23:56 [PATCH 0/4] xfstests: xfs and hole punch test fixes Dave Chinner
2014-02-02 23:56 ` [PATCH 1/4] xfs/199: enforce v4 superblock format for test Dave Chinner
2014-02-03 7:38 ` Christoph Hellwig
2014-02-02 23:56 ` [PATCH 2/4] xfs/291: fix spurious ENOSPC errors Dave Chinner
2014-02-03 7:38 ` Christoph Hellwig
2014-02-02 23:56 ` [PATCH 3/4] generic: _test_generic_punch not blocksize clean Dave Chinner
2014-02-03 7:39 ` Christoph Hellwig
2014-02-02 23:56 ` [PATCH 4/4] generic: inconsistent initial state for test_generic_punch Dave Chinner
2014-02-03 7:40 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140203074005.GD16476@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox