From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs/189: noattr2 invalid for CRC enabled filesystems
Date: Fri, 7 Feb 2014 09:47:54 -0800 [thread overview]
Message-ID: <20140207174754.GA31464@infradead.org> (raw)
In-Reply-To: <1391590000-7171-1-git-send-email-david@fromorbit.com>
On Wed, Feb 05, 2014 at 07:46:40PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> Version 5 filesystems always have attr2 format enabled, and it
> cannot be turned off via the noattr2 mount option. As such, attempts
> to mount with noattr2 will be rejected and this causes cascading
> failures within the test.
>
> Hence detect if we've created a CRC enabled filesystem, and if this
> is the case _notrun the test.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
> ---
> tests/xfs/189 | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/tests/xfs/189 b/tests/xfs/189
> index 27bfb63..addf7ce 100755
> --- a/tests/xfs/189
> +++ b/tests/xfs/189
> @@ -241,7 +241,16 @@ _require_scratch
> unset SCRATCH_RTDEV
> unset SCRATCH_LOGDEV
>
> -_scratch_mkfs_xfs | _filter_mkfs 2>/dev/null
> +_scratch_mkfs_xfs | _filter_mkfs 2> $tmp.mkfs
> +
> +# check to see if we've made a CRC enabled filesystem. If so,
> +# we can't run the test because CRc enabled filesystems don't support
> +# noattr2 mount options and this will cause cascading failures that are
> +# impossible to filter.
> +. $tmp.mkfs
> +if [ $crc -eq 1 ]; then
> + _notrun "Filesystem CRCs enabled, noattr2 is not supported."
> +fi
I really don't like opencoding this. Shouldn't we instead simplfy
pass a nocrc argument to _scratch_mkfs_xfs?
Alternatively this magic should move into a helper.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-02-07 17:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-05 8:46 [PATCH] xfs/189: noattr2 invalid for CRC enabled filesystems Dave Chinner
2014-02-07 17:47 ` Christoph Hellwig [this message]
2014-02-10 1:52 ` Dave Chinner
2014-02-10 10:45 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140207174754.GA31464@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox